In addition to the parent ID property, the new scripting feature adds a newscriptStatistics property. This can be calling jobs.get on a script child job in the APIs Explorer.

Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Follow-up to#9190 🦕

tswast added the api: bigqueryIssues related to the BigQuery API. label

Oct 8, 2019

tswast requested review froma team andshollyman

October 8, 2019 20:26

googlebot added the cla: yesThis human has signed the Contributor License Agreement. label

Oct 8, 2019

feat(bigquery): add script statistics to job resource

4f31fc3

tswast force-pushed thebq-script-stats branch from77b24f0 to4f31fc3Compare

October 8, 2019 20:27

tswast changed the title~~feat(bigquery): Add script statistics to job resource.~~feat(bigquery): add script statistics to job resource

Oct 8, 2019

tseaver suggested changes

Oct 9, 2019

View reviewed changes

Copy link

Contributor

tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add explicit unit test coverage for theScriptStackFrame andScriptStatistics classes.

add explicit unit test coverage for the ScriptStackFrame and ScriptSt…

8f00cc4

…atistics classes

tswast requested a review fromtseaver

October 9, 2019 20:02

shollyman approved these changes

Oct 9, 2019

View reviewed changes

Copy link

Contributor

shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Iterating by parent was already implemented, as were the ParentJobId and NumChildJobs fields on JobStatistics. This rounds out the implementation. I am assuming integration testing will happen in the context of samples.