- Notifications
You must be signed in to change notification settings - Fork1.6k
Storage: Add benchwrapper, support STORAGE_EMULATOR_HOST.#9219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
busunkim96 commentedSep 12, 2019
@jadekler Would you mind running |
jeanbza commentedSep 12, 2019
Done! |
tseaver left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In addition to in-line review comments, please blacken the code (nox -e blacken).
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
jeanbza commentedSep 12, 2019
I did that already - is there more I need to do? :) |
googlebot commentedSep 13, 2019
All (the pull request submitter and all commit authors) CLAs are signed,but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️Googlers:Go here for more info. |
tseaver commentedSep 13, 2019
@jadekler I've pushed the DRY changes to your branch. |
tseaver left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM pending CI green. @jadekler you will need to tweak the CLA stuff.
googlebot commentedSep 13, 2019
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️Googlers:Go here for more info. |
jeanbza commentedSep 13, 2019
@googlebot I consent |
jeanbza commentedSep 13, 2019
Thank you!! |
jeanbza commentedSep 14, 2019
(could somebody merge? I don't have powers to :) ) |
googlebot commentedSep 14, 2019
All (the pull request submitter and all commit authors) CLAs are signed,but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️Googlers:Go here for more info. |
jeanbza commentedSep 14, 2019
@googlebot I consent. |
1 similar comment
tseaver commentedSep 16, 2019
@googlebot I consent. |
googlebot commentedSep 16, 2019
CLAs look good, thanks! ℹ️Googlers:Go here for more info. |
No description provided.