Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Storage: Add benchwrapper, support STORAGE_EMULATOR_HOST.#9219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tseaver merged 5 commits intogoogleapis:masterfromjeanbza:storage_emulator
Sep 16, 2019

Conversation

@jeanbza
Copy link
Contributor

No description provided.

@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement. labelSep 12, 2019
@tseavertseaver changed the titlestorage: add benchwrapper, support STORAGE_EMULATOR_HOSTStorage: Add benchwrapper, support STORAGE_EMULATOR_HOST.Sep 12, 2019
@tseavertseaver added the api: storageIssues related to the Cloud Storage API. labelSep 12, 2019
@busunkim96
Copy link
Contributor

@jadekler Would you mind runningnox -s blacken to appease the linter? That will run a code formatter.

@jeanbza
Copy link
ContributorAuthor

@jadekler Would you mind runningnox -s blacken to appease the linter? That will run a code formatter.

Done!

Copy link
Contributor

@tseavertseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In addition to in-line review comments, please blacken the code (nox -e blacken).

@jeanbza
Copy link
ContributorAuthor

nox -e blacken

I did that already - is there more I need to do? :)

deklerk at deklerk-macbookpro2 in ~/workspace/google-cloud-python/storage on storage_emulator$ nox -e blackennox > Running session blackennox > Creating virtual environment (virtualenv) using python3.6 in .nox/blackennox > pip install black==19.3b0nox > black docs google tests noxfile.py setup.pyAll done! ✨ 🍰 ✨31 files left unchanged.nox > Session blacken was successful.deklerk at deklerk-macbookpro2 in ~/workspace/google-cloud-python/storage on storage_emulator$

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed,but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only@googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set thecla label toyes (if enabled on your project).

ℹ️Googlers:Go here for more info.

@googlebotgooglebot added cla: noThis human has *not* signed the Contributor License Agreement. and removed cla: yesThis human has signed the Contributor License Agreement. labelsSep 13, 2019
@tseaver
Copy link
Contributor

@jadekler I've pushed the DRY changes to your branch.

Copy link
Contributor

@tseavertseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM pending CI green. @jadekler you will need to tweak the CLA stuff.

@busunkim96busunkim96 added cla: yesThis human has signed the Contributor License Agreement. and removed cla: noThis human has *not* signed the Contributor License Agreement. labelsSep 13, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️Googlers:Go here for more info.

@jeanbza
Copy link
ContributorAuthor

@googlebot I consent

@jeanbza
Copy link
ContributorAuthor

@jadekler I've pushed the DRY changes to your branch.

Thank you!!

@jeanbza
Copy link
ContributorAuthor

(could somebody merge? I don't have powers to :) )

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed,but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only@googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set thecla label toyes (if enabled on your project).

ℹ️Googlers:Go here for more info.

@googlebotgooglebot added cla: noThis human has *not* signed the Contributor License Agreement. and removed cla: yesThis human has signed the Contributor License Agreement. labelsSep 14, 2019
@jeanbza
Copy link
ContributorAuthor

@googlebot I consent.

1 similar comment
@tseaver
Copy link
Contributor

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️Googlers:Go here for more info.

@googlebotgooglebot added cla: yesThis human has signed the Contributor License Agreement. and removed cla: noThis human has *not* signed the Contributor License Agreement. labelsSep 16, 2019
@tseavertseaver merged commit795bb32 intogoogleapis:masterSep 16, 2019
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull requestSep 18, 2019
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull requestSep 18, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@busunkim96busunkim96Awaiting requested review from busunkim96

@crwilcoxcrwilcoxAwaiting requested review from crwilcox

@frankynfrankynAwaiting requested review from frankyn

1 more reviewer

@tseavertseavertseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storageIssues related to the Cloud Storage API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeanbza@busunkim96@googlebot@tseaver

[8]ページ先頭

©2009-2025 Movatter.jp