- Notifications
You must be signed in to change notification settings - Fork1.6k
BigQuery: Add support for array parameters to Cursor.execute()#9189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
tswast left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looking good. Just want to make sure we don't confuse dictionaries as if they were array-like.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
tswast approved these changesSep 10, 2019
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull requestSep 11, 2019
…eapis#9189)* Add support for array params to Cursor.execute()* Raise NotImplementedError for STRUCT-like values
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull requestSep 18, 2019
…eapis#9189)* Add support for array params to Cursor.execute()* Raise NotImplementedError for STRUCT-like values
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
api: bigqueryIssues related to the BigQuery API. cla: yesThis human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes#9177.
This PR adds support for array-like query parameters.
How to test
Run the example from the issue description (slightly modified, see below). Binding an array-like parameter to a parametrized query should not raise an error, and the following should work as expected:
Mind that scanning arrays requires using
IN UNNEST(...)construct (docs), thus theUNNESTfunction needs to be added to the query from the issue description:Footnotes