- Notifications
You must be signed in to change notification settings - Fork1.6k
BigQuery: Add 'max_results' param to 'QueryJob.result()'.#9167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
BigQuery: Add 'max_results' param to 'QueryJob.result()'.#9167
Uh oh!
There was an error while loading.Please reload this page.
Conversation
tswast left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I know it's a bit silly to do so, but let's add a unit test to thetest_job.py module to make suremax_results works as expected.
tswast left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks great, thanks!
* added max_results param to QueryJob.result()* added test to check that max_results param appears in tabledata.list call arguments
* added max_results param to QueryJob.result()* added test to check that max_results param appears in tabledata.list call arguments
First of 3 PRs towards resolving#9105 as described in review for#9147