- Notifications
You must be signed in to change notification settings - Fork1.6k
Storage: Expose id field for HMAC key#9115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This is exposed in the client libraries for other languages andis required for the samples to match.
ContributorAuthor
tritone commentedAug 27, 2019
This addresses issue#9114 . |
tseaver approved these changesAug 27, 2019
Contributor
tseaver commentedAug 27, 2019
@tritone Unit tests were broken by yesterday's release of |
ContributorAuthor
tritone commentedAug 28, 2019
@tseaver looks like that did the trick; thanks! |
HemangChothani pushed a commit to HemangChothani/google-cloud-python that referenced this pull requestAug 29, 2019
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull requestSep 18, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is exposed in the client libraries for other languages and
is required for the samples to match.