- Notifications
You must be signed in to change notification settings - Fork1.6k
BigQuery: Add support for unsetting LoadJobConfig schema#9077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| config.schema=None | ||
| self.assertNotIn("schema",config._properties["load"]) | ||
| config.schema=None# no error, idempotent operation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This extra assignment is to catch fragile implementations such asdel self._properties["load"]["schema"]
(nope, did not do it myself, but I've seen similar bugs in the past 😆 )
tswast left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for handling this so quickly!
Closes#9074.
This PR adds a public way of unsetting a schema from a
LoadJobConfig.How to test
Create a
LoadJobConfigwith aschemaattribute, then setschematoNone--> the schema should be cleared.