- Notifications
You must be signed in to change notification settings - Fork1.6k
BigQuery: Pin pyarrow version in tests.#8784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This is a workaround for a possible regression in pyarrow handling of NaN vsNULL in float columns.
tseaver left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we need an open issue to remind us to revert this change when PyArrow releases a fix?
tseaver left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We need to pin for unit tests, particularly.
tswast commentedJul 25, 2019
Found some documentation about this behavior:https://arrow.apache.org/docs/python/data.html#none-values-and-nan-handling Since we are converting from pandas (which uses NaN as a placeholder for NULL for numpy reasons), this behavior is expected. I'll open a new PR that updates the test. |
This is a workaround for a possible regression in pyarrow handling of NaN vs
NULL in float columns.