Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

PubSub: Document different PubSub received message types#8468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sduskis merged 1 commit intogoogleapis:masterfromplamut:iss-7128
Jun 24, 2019

Conversation

@plamut
Copy link
Contributor

@plamutplamut commentedJun 24, 2019
edited
Loading

Closes#7128.

This PR documents different PubSub received message types depending on whether a synchronous or asynchronous method is used to pull messages.

Disclaimer: I was not able to generate the docs locally due to network timeouts when downloading intersphinx inventory files from external sources. Please double check that the generated intra-doc links work.

How to test

Steps to perform:

  • Generate the pubsub docs locally (from inside thepubsub/ directory):
    $ nox -f noxfile.py -s docs
  • Open the generated docs for subscriber:
    $ google-chrome "file://$GOOG_CLOUD_PYTHON_DIR/pubsub/docs/_build/html//subscriber/index.html"

Expected result:
The different received message type are clearly described, the code samples are valid, and the intra-doc links work.

@plamutplamut added api: pubsubIssues related to the Pub/Sub API. type: docsImprovement to the documentation for an API. labelsJun 24, 2019
@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement. labelJun 24, 2019
@plamutplamut changed the titlePubSub: Document different PuSub received message typesPubSub: Document different PubSub received message typesJun 24, 2019
@plamut
Copy link
ContributorAuthor

@enugentdt As the issue reporter, do you the docs changes here in this PR clear enough to answer all the questions you had when opening the issue?

Copy link
Contributor

@anguillanneufanguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@sduskissduskis merged commit20f83b1 intogoogleapis:masterJun 24, 2019
@plamutplamut deleted the iss-7128 branchJune 24, 2019 17:35
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@anguillanneufanguillanneufanguillanneuf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anguillanneufanguillanneuf

Labels

api: pubsubIssues related to the Pub/Sub API.cla: yesThis human has signed the Contributor License Agreement.type: docsImprovement to the documentation for an API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PubSub: Inconsistent documentation on received message types

4 participants

@plamut@anguillanneuf@sduskis@googlebot

[8]ページ先頭

©2009-2025 Movatter.jp