- Notifications
You must be signed in to change notification settings - Fork1.6k
PubSub: Add system tests for PubSub clients#8277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
plamut commentedJun 11, 2019
Uh oh!
There was an error while loading.Please reload this page.
The PubSub backend does not give any guarantees about when a messagewill be re-delivered after seeking back to a snapshot, it will onlybe delivered "eventually". That causes flakiness in the snapshotstest.Since the test cannot wait for an indefinite amount of time, thiscommit removes it in order to not randomly break the CI builds.
anguillanneuf approved these changesJun 20, 2019
Contributor
anguillanneuf left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
api: pubsubIssues related to the Pub/Sub API. cla: yesThis human has signed the Contributor License Agreement. 🚨This issue needs some love.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes#4031.
The title says it all - this PR adds the missing system tests mentioned in the issue description:
Creating / seeking snapshots.⬅️ Removed, because the server only guarantees eventual re-delivery, and a test cannot wait for a fixed amount of time, causes flakiness.