Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Move table and dataset snippets to samples/ directory#7683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tswast merged 4 commits intogoogleapis:masterfromtswast:bq-snippets-rebased
Apr 10, 2019

Conversation

@tswast
Copy link
Contributor

@tswasttswast commentedApr 9, 2019•
edited
Loading

These samples follow the same pattern as the Models API samples, following our rubric guidelines for 1 sample per file.

This work was completed by@lbristol88 and reviewed on my personal fork, as the Models API PR hadn't yet merged when she started this work.

@tswasttswast added api: bigqueryIssues related to the BigQuery API. type: docsImprovement to the documentation for an API. labelsApr 9, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning thecla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set thecla label toyes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️Googlers:Go here for more info.

@googlebotgooglebot added the cla: noThis human has *not* signed the Contributor License Agreement. labelApr 9, 2019
@sduskissduskis added cla: yesThis human has signed the Contributor License Agreement. and removed cla: noThis human has *not* signed the Contributor License Agreement. labelsApr 9, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️Googlers:Go here for more info.

@googlebotgooglebot added cla: noThis human has *not* signed the Contributor License Agreement. and removed cla: yesThis human has signed the Contributor License Agreement. labelsApr 10, 2019
@tswasttswast added cla: yesThis human has signed the Contributor License Agreement. and removed cla: noThis human has *not* signed the Contributor License Agreement. labelsApr 10, 2019
@tswasttswast marked this pull request as ready for reviewApril 10, 2019 18:12
@tswasttswast added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelApr 10, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelApr 10, 2019
* Add `samples/create_table.py` sample code.* Remove `test_create_table` from snippets collection.
* Added delete dataset function* Added get dataset function* Added list dataset function* Added update dataset description sample* Added update dataset access sample* Added update dataset table expiration sample* Added tests for dataset samples and updated docs* Removing original update dataset access from snippets file.* Moved all dataset tests into own file. Made changes based on feedback.* Made changes based on feedback* Removed unnecessary use of random_dataset_id in tests and removed one_day_ms fixture* Removed unnecessary constant* Stored the math as a constant to make it look cleaner.
* Updated list tables snippet along with test.* Removed old list table snippet and upated location of sample
@googlebotgooglebot added cla: noThis human has *not* signed the Contributor License Agreement. and removed cla: yesThis human has signed the Contributor License Agreement. labelsApr 10, 2019
@tswasttswast added cla: yesThis human has signed the Contributor License Agreement. and removed cla: noThis human has *not* signed the Contributor License Agreement. labelsApr 10, 2019
@googleapisgoogleapis deleted a comment fromgooglebotApr 10, 2019
@googleapisgoogleapis deleted a comment fromgooglebotApr 10, 2019
@googleapisgoogleapis deleted a comment fromgooglebotApr 10, 2019
@googleapisgoogleapis deleted a comment fromgooglebotApr 10, 2019
@tswasttswast merged commit7ba0220 intogoogleapis:masterApr 10, 2019
@tswasttswast deleted the bq-snippets-rebased branchApril 10, 2019 20:19
tswast added a commit to tswast/google-cloud-python that referenced this pull requestApr 11, 2019
* Move create table sample to samples directoryThese samples follow the same pattern as the Models API samples, following our rubric guidelines for 1 sample per file.This work was completed by Layla and reviewed on Tim's personal fork, as the Models API PR hadn't yet merged when she started this work.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@crwilcoxcrwilcoxAwaiting requested review from crwilcox

@shollymanshollymanAwaiting requested review from shollyman

@steffnaysteffnayAwaiting requested review from steffnay

Assignees

No one assigned

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.type: docsImprovement to the documentation for an API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tswast@googlebot@sduskis@yoshi-kokoro@lbristol88
[8]ページ先頭
©2009-2025 Movatter.jp