- Notifications
You must be signed in to change notification settings - Fork1.6k
Add parameterized test for from_rfc3339 with nanos#7675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
crwilcox merged 2 commits intogoogleapis:masterfromcrwilcox:add-parameterized-datetime-nano-testMay 20, 2019
Merged
Add parameterized test for from_rfc3339 with nanos#7675
crwilcox merged 2 commits intogoogleapis:masterfromcrwilcox:add-parameterized-datetime-nano-testMay 20, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
sduskis approved these changesApr 8, 2019
tseaver suggested changesApr 17, 2019
Contributor
tseaver left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
TheWebRisk failure seems clearly unrelated. However, theAPI core failures (lint, pytype) need to be fixed.
ContributorAuthor
crwilcox commentedMay 20, 2019
The failures are unrelated. This is a test only change. Merging |
Contributor
tseaver commentedMay 20, 2019
@crwilcox We still need to fix the |
parthea pushed a commit that referenced this pull requestNov 24, 2025
* Add parameterized test for from_rfc3339 with nanos
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking into another issue I noticed we didn't seem to test this constructor much (if at all).