Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

BigQuery: add destination table properties to 'LoadJobConfig'.#6202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tseaver merged 26 commits intomasterfrom5093-bigquery-destination_table_props
Oct 17, 2018

Conversation

@tseaver
Copy link
Contributor

Closes#5093.

This PR includes a bunch of new explicit unit test cases / assertions forLoadJobConfig, and reorders the properties alphabetically, to make it easier to match up with the docs.

/cc@yiga2.

@tseavertseaver added the api: bigqueryIssues related to the BigQuery API. labelOct 12, 2018
@tseavertseaver requested a review fromtswastOctober 12, 2018 22:37
@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement. labelOct 12, 2018
Copy link
Contributor

@tswasttswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@tseavertseaver removed the request for review fromcrwilcoxOctober 17, 2018 02:01
@tseavertseaver added do not mergeIndicates a pull request not ready for merge, due to either quality or timing. status: blockedResolving the issue is dependent on other work. labelsOct 17, 2018
@tseaver
Copy link
ContributorAuthor

Merge blocked pending resolution of#6231, and a re-run of theKokoro Bigquery job (how?).

@tswasttswast added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelOct 17, 2018
@kokoro-teamkokoro-team removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelOct 17, 2018
@tseavertseaver added kokoro:force-runAdd this label to force Kokoro to re-run the tests. and removed do not mergeIndicates a pull request not ready for merge, due to either quality or timing. status: blockedResolving the issue is dependent on other work. labelsOct 17, 2018
@kokoro-teamkokoro-team removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelOct 17, 2018
@tseaver
Copy link
ContributorAuthor

None are relevant to this PR, which is purely BigQuery.

@theacodes looks like Kokoro has gone from skipping everything (#6231) to running all tests regardless?

Note question posted to issue#5093:  should 'max_bad_rows' and'skip_leading_rows' match in how the mangle / parse the value in theresource?  Docs say it is an integer.
It should remove the 'timePartitioning' sub-key altogether.
… LJC tests.Fix bug revealed thereby in 'LJC.destination_encryption_configuration' setter.
@tseavertseaverforce-pushed the5093-bigquery-destination_table_props branch from554b323 to2a920d1CompareOctober 17, 2018 20:03
@tseaver
Copy link
ContributorAuthor

Rebased again to pick upapi_core andpubsub testing changes from PRs#6242 and#6243.

@tseavertseaver merged commitcf806f2 intomasterOct 17, 2018
@tseavertseaver deleted the 5093-bigquery-destination_table_props branchOctober 17, 2018 21:00
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tswasttswasttswast approved these changes

Assignees

No one assigned

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@tswast@googlebot@kokoro-team
[8]ページ先頭
©2009-2025 Movatter.jp