Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Clarify GCS URL signing limitations on GCE#6104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tseaver merged 3 commits intogoogleapis:masterfromzulkifal:patch-1
Sep 28, 2018

Conversation

@zulkifal
Copy link
Contributor

The line 'If you are on Google Compute Engine, you can't generate a signed URL' wrongly implies URL generation is impossible from GCE. Adding clarification that this line only holds true when GCE is using GCE service account.

The line 'If you are on Google Compute Engine, you can't generate a signed URL' wrongly implies URL generation is impossible from GCE. Adding clarification that this line only holds true when GCE is using GCE service account.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝Please visithttps://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g.I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebotgooglebot added the cla: noThis human has *not* signed the Contributor License Agreement. labelSep 25, 2018
@zulkifal
Copy link
ContributorAuthor

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebotgooglebot added cla: yesThis human has signed the Contributor License Agreement. and removed cla: noThis human has *not* signed the Contributor License Agreement. labelsSep 25, 2018
@zulkifalzulkifal changed the titleUpdate blob.pyClarify GCS URL signing limitations on GCESep 25, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning thecla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set thecla label toyes (if enabled on your project), and then merge this pull request when appropriate.

@googlebotgooglebot added cla: noThis human has *not* signed the Contributor License Agreement. and removed cla: yesThis human has signed the Contributor License Agreement. labelsSep 26, 2018
@tseavertseaver added api: storageIssues related to the Cloud Storage API. auth type: docsImprovement to the documentation for an API. labelsSep 26, 2018
@theacodestheacodes added cla: yesThis human has signed the Contributor License Agreement. and removed cla: noThis human has *not* signed the Contributor License Agreement. labelsSep 28, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@tseavertseaver merged commitc8098c9 intogoogleapis:masterSep 28, 2018
@tseaver
Copy link
Contributor

@zulkifal Thanks for the patch!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@theacodestheacodesAwaiting requested review from theacodes

Assignees

No one assigned

Labels

api: storageIssues related to the Cloud Storage API.authcla: yesThis human has signed the Contributor License Agreement.type: docsImprovement to the documentation for an API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zulkifal@googlebot@tseaver@theacodes

[8]ページ先頭

©2009-2025 Movatter.jp