Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adding ability to give default QueryJobConfig to Client#6088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tswast merged 11 commits intogoogleapis:masterfrommarketdial:master
Sep 26, 2018
Merged

Adding ability to give default QueryJobConfig to Client#6088

tswast merged 11 commits intogoogleapis:masterfrommarketdial:master
Sep 26, 2018

Conversation

@blainehansen
Copy link
Contributor

closes#5183

This isn't a complete request (I need to do things like fill out the Contributor License Agreements, get coverage all the way to 100%, etc), but I wanted to begin the discussion to see if this was an acceptable direction. Only QueryJobConfig has been implemented, but the other types shouldn't be too difficult, since I've added a_JobConfig.fill_from_default method.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝Please visithttps://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g.I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebotgooglebot added the cla: noThis human has *not* signed the Contributor License Agreement. labelSep 24, 2018
@googlebot
Copy link

CLAs look good, thanks!

@googlebotgooglebot added cla: yesThis human has signed the Contributor License Agreement. and removed cla: noThis human has *not* signed the Contributor License Agreement. labelsSep 24, 2018
@tseaver
Copy link
Contributor

@blainehansen

Making a PR from yourmaster branch makes things hard for you over the long term: it creates barriers to synchronizing with this repository'smaster over time.

WRT the test failures, there is missing line / branch coverage for:

google/cloud/bigquery/client.py               374      1    160      1    99%   1244, 1236->1244

which is the case where nojob_config is passed.

@blainehansen
Copy link
ContributorAuthor

@tseaver Sorry about not creating a feature branch ha, I don't expect to maintain a fork for a long period, I was just hoping to include this feature, but I shouldn't have cut corners.

defquery(
self,query,job_config=None,job_id=None,job_id_prefix=None,
self,query,
job_config=None,override_job_config=False,

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Copy link
Contributor

@tswasttswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking good, thanks! Just a few comments. I'm not convinced we need themerge_job_config argument yet.

Copy link
Contributor

@tswasttswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Love it! Thank you so much for your contribution,@blainehansen.

FYI: I've made fill_from_default "private" by prefixing an underscore, because I don't think it's necessary to add this method to the public API interface. (It's fine to use from other modules within this library.)

@tseaver Please take a look.

@blainehansen
Copy link
ContributorAuthor

👍 yeah making that private is definitely a better choice 😄

@tswasttswast merged commitcf04f6d intogoogleapis:masterSep 26, 2018
@blainehansen
Copy link
ContributorAuthor

🎊 🎊 🎊

Thanks everyone!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tswasttswasttswast approved these changes

@theacodestheacodesAwaiting requested review from theacodes

+1 more reviewer

@tseavertseavertseaver requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery: ability to set default job / table / dataset configs in client class

4 participants

@blainehansen@googlebot@tseaver@tswast

[8]ページ先頭

©2009-2025 Movatter.jp