Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

BigQuery: Can iterate over QueryJob results without explicitly calling result()#4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
alixhami merged 1 commit intogoogleapis:masterfromalixhami:bq-queryjob-iter
Nov 13, 2017

Conversation

@alixhami
Copy link
Contributor

No description provided.

@alixhamialixhami added the api: bigqueryIssues related to the BigQuery API. labelNov 6, 2017
@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement. labelNov 6, 2017
@theacodes
Copy link
Contributor

I'd like@tswast or@jba to take a look from a BigQuery perspective as well.

@jba
Copy link
Contributor

jba commentedNov 6, 2017

LGTM, but I will defer to Tim.

Copy link
Contributor

@tswasttswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice.

I wonder if this change makesClient.query_rows() unnecessary?

@alixhami
Copy link
ContributorAuthor

@tswast If the purpose ofClient.query_rows() was just to get query results without callingresult(), then it would be unnecessary. Are there other uses for it, or should I remove it in another PR?

@alixhamialixhami merged commitd3999a8 intogoogleapis:masterNov 13, 2017
dhermes added a commit to dhermes/google-cloud-python that referenced this pull requestNov 13, 2017
This happened becausegoogleapis#4350 was sent beforegoogleapis#4355 was merged.
dhermes added a commit that referenced this pull requestNov 13, 2017
This happened because#4350 was sent before#4355 was merged.
@tswast
Copy link
Contributor

Talked in person. Let's removequery_rows in another PR. I can think of no other uses for it.

chemelnucfin pushed a commit to chemelnucfin/google-cloud-python that referenced this pull requestNov 15, 2017
chemelnucfin pushed a commit to chemelnucfin/google-cloud-python that referenced this pull requestNov 15, 2017
chemelnucfin pushed a commit to chemelnucfin/google-cloud-python that referenced this pull requestNov 15, 2017
chemelnucfin pushed a commit to chemelnucfin/google-cloud-python that referenced this pull requestNov 15, 2017
@alixhamialixhami deleted the bq-queryjob-iter branchNovember 16, 2017 20:12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tswasttswasttswast approved these changes

@dhermesdhermesAwaiting requested review from dhermes

@lukesneeringerlukesneeringerAwaiting requested review from lukesneeringer

+1 more reviewer

@theacodestheacodestheacodes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alixhami@theacodes@jba@tswast@googlebot
[8]ページ先頭
©2009-2025 Movatter.jp