- Notifications
You must be signed in to change notification settings - Fork1.6k
Vendor in apitools subset#388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coveralls commentedNov 25, 2014
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
dhermes commentedNov 26, 2014
What is the diff between the code inhttps://github.com/craigcitro/apitools and those committed here? Can we also commit
If there is no diff, I'd be a fan of using a Even if there is a diff, we could apply the |
tseaver commentedNov 26, 2014
This change copies in only the four modules expected (in#334) to be needed. It replaces the package-level Submodules are demon-spawn. :) We explicitly don't want all of apitools, because the bits that use I can see no benefit to applying a patch: we are going to have to garden these files by hand, but only until@craigcitro can get |
coveralls commentedNov 26, 2014
dhermes commentedNov 26, 2014
I madehttps://gist.github.com/dhermes/0ba88c5dab4be4e60b9e with a patch file. I am fine gardening the files by hand, but want to keep a clear record of how and when we changed it. Hopefully it is quite temporary. As for the imports, is there any reason we don't instead use absolute imports, since the path is fully under our control? |
coveralls commentedDec 2, 2014
- '__init__.py' files are stubs, w/o namespace support. Deleted package-level 'from <foo> import *' convenience imports.- Non-'__init__.py' files pulled from:craigcitro/apitools@e5a5c36- Absolute imports converted to explicit relative.
tseaver commentedDec 2, 2014
Rebased against master, adding explicit reference to source commit, plus description of deltas. |
coveralls commentedDec 2, 2014
dhermes commentedDec 2, 2014
Can you check in the content from the source commit as part of the repo? People are likely to give up going through commit history to find it. I know this seems a bit over the top, but there is a chance we'll be burdened with this code for awhile and I don't want to lose track of the delta from the source of "truth". |
tseaver commentedDec 2, 2014
I'll redo on a different PR. |
* fix(deps): allow protobuf 3.19.5* explicitly exclude protobuf 4.21.0
* fix: integrate gapic-generator-python-1.4.1 and enable more py_test targetsPiperOrigin-RevId: 473833416Source-Link:googleapis/googleapis@565a550Source-Link:googleapis/googleapis-gen@1ee1a06Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWVlMWEwNmM2ZGUzY2E4Yjg0MzU3MmMxZmRlMDU0OGY4NDIzNjk4OSJ9* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.mdCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…ge_classify_text.py (#388)* docs: specify client library version requirement* clarify commentCo-authored-by: Anthonios Partheniou <partheniou@google.com>
* chore: Update gapic-generator-python to v1.8.2PiperOrigin-RevId: 504289125Source-Link:googleapis/googleapis@38a48a4Source-Link:googleapis/googleapis-gen@b2dc226Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.mdCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
The previous file is removed since the parent project is deleted. Changed to use publicly available file.
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
)Source-Link:googleapis/synthtool@7804adePost-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:eede5672562a32821444a8e803fb984a6f61f2237ea3de229d2de24453f4ae7d
* docs: Minor formattingchore: Update gapic-generator-python to v1.11.5build: Update rules_python to 0.24.0PiperOrigin-RevId: 563436317Source-Link:googleapis/googleapis@42fd37bSource-Link:googleapis/googleapis-gen@280264cCopy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjgwMjY0Y2EwMmZiOTMxNmI0MjM3YTk2ZDBhZjFhMjM0M2E4MWE1NiJ9* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md---------Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* fix(deps): Require google-api-core >=1.34.0, >=2.11.0fix: Drop usage of pkg_resourcesfix: Fix timeout default valuesdocs(samples): Snippetgen should call await on the operation coroutine before calling resultPiperOrigin-RevId: 493260409Source-Link:googleapis/googleapis@fea4387Source-Link:googleapis/googleapis-gen@387b734Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* add gapic_version.pyCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>Co-authored-by: Anthonios Partheniou <partheniou@google.com>
🤖 I have created a release *beep* *boop*---<details><summary>google-ai-generativelanguage: 0.3.4</summary>##[0.3.4](google-ai-generativelanguage-v0.3.3...google-ai-generativelanguage-v0.3.4)(2023-09-30)### Documentation* Minor formatting([#11630](#11630))([b176996](b176996))</details><details><summary>google-apps-script-type: 0.3.4</summary>##[0.3.4](google-apps-script-type-v0.3.3...google-apps-script-type-v0.3.4)(2023-09-30)### Documentation* Minor formatting([#11630](#11630))([b176996](b176996))</details><details><summary>google-area120-tables: 0.11.4</summary>##[0.11.4](google-area120-tables-v0.11.3...google-area120-tables-v0.11.4)(2023-09-30)### Documentation* Minor formatting([#11630](#11630))([b176996](b176996))</details><details><summary>google-cloud-access-approval: 1.11.3</summary>##[1.11.3](google-cloud-access-approval-v1.11.2...google-cloud-access-approval-v1.11.3)(2023-09-30)### Documentation* Minor formatting([#11630](#11630))([b176996](b176996))</details><details><summary>google-cloud-advisorynotifications: 0.3.1</summary>##[0.3.1](google-cloud-advisorynotifications-v0.3.0...google-cloud-advisorynotifications-v0.3.1)(2023-09-30)### Features* add new RPCs GetSettings, UpdateSettings and new messages Settings,NotificationSettings, GetSettingsRequest, UpdateSettingsRequest([e395513](e395513))</details><details><summary>google-cloud-alloydb: 0.3.3</summary>##[0.3.3](google-cloud-alloydb-v0.3.2...google-cloud-alloydb-v0.3.3)(2023-09-30)### Features* Add support to generate client certificate and get connection info([0f72d58](0f72d58))* Add support to generate client certificate and get connection info forauth proxy in AlloyDB v1([#11764](#11764))([0f72d58](0f72d58))</details><details><summary>google-cloud-api-gateway: 1.7.3</summary>##[1.7.3](google-cloud-api-gateway-v1.7.2...google-cloud-api-gateway-v1.7.3)(2023-09-30)### Documentation* Minor formatting([#11630](#11630))([b176996](b176996))</details><details><summary>google-cloud-api-keys: 0.5.4</summary>##[0.5.4](google-cloud-api-keys-v0.5.3...google-cloud-api-keys-v0.5.4)(2023-09-30)### Documentation* Minor formatting([#11630](#11630))([b176996](b176996))</details><details><summary>google-cloud-apigee-connect: 1.7.3</summary>##[1.7.3](google-cloud-apigee-connect-v1.7.2...google-cloud-apigee-connect-v1.7.3)(2023-09-30)### Documentation* Minor formatting([#11630](#11630))([b176996](b176996))</details><details><summary>google-cloud-apigee-registry: 0.6.4</summary>##[0.6.4](google-cloud-apigee-registry-v0.6.3...google-cloud-apigee-registry-v0.6.4)(2023-09-30)### Documentation* Minor formatting([#11630](#11630))([b176996](b176996))</details><details><summary>google-cloud-appengine-logging: 1.3.2</summary>##[1.3.2](google-cloud-appengine-logging-v1.3.1...google-cloud-appengine-logging-v1.3.2)(2023-09-30)### Documentation* Minor formatting([#11630](#11630))([b176996](b176996))</details><details><summary>google-cloud-artifact-registry: 1.8.4</summary>##[1.8.4](google-cloud-artifact-registry-v1.8.3...google-cloud-artifact-registry-v1.8.4)(2023-09-30)### Bug Fixes* make repository and repository_id in CreateRepository required([3b8ea3e](3b8ea3e))</details><details><summary>google-cloud-bare-metal-solution: 1.5.1</summary>##[1.5.1](google-cloud-bare-metal-solution-v1.5.0...google-cloud-bare-metal-solution-v1.5.1)(2023-09-30)### Documentation* Minor formatting([#11630](#11630))([b176996](b176996))</details><details><summary>google-cloud-batch: 0.17.1</summary>##[0.17.1](google-cloud-batch-v0.17.0...google-cloud-batch-v0.17.1)(2023-09-30)### Documentation* update batch PD interface support([a300b07](a300b07))</details><details><summary>google-cloud-beyondcorp-appconnections:0.4.4</summary>##[0.4.4](google-cloud-beyondcorp-appconnections-v0.4.3...google-cloud-beyondcorp-appconnections-v0.4.4)(2023-09-30)### Documentation* Minor formatting([#11630](#11630))([b176996](b176996))</details><details><summary>google-cloud-beyondcorp-appconnectors: 0.4.4</summary>##[0.4.4](google-cloud-beyondcorp-appconnectors-v0.4.3...google-cloud-beyondcorp-appconnectors-v0.4.4)(2023-09-30)### Documentation* Minor formatting([#11630](#11630))([b176996](b176996))</details><details><summary>google-cloud-beyondcorp-appgateways: 0.4.4</summary>##[0.4.4](google-cloud-beyondcorp-appgateways-v0.4.3...google-cloud-beyondcorp-appgateways-v0.4.4)(2023-09-30)### Documentation* Minor formatting([#11630](#11630))([b176996](b176996))</details><details><summary>google-cloud-beyondcorp-clientconnectorservices:0.4.4</summary>##[0.4.4](google-cloud-beyondcorp-clientconnectorservices-v0.4.3...google-cloud-beyondcorp-clientconnectorservices-v0.4.4)(2023-09-30)### Documentation* Minor formatting([#11630](#11630))([b176996](b176996))</details><details><summary>google-cloud-beyondcorp-clientgateways:0.4.3</summary>##[0.4.3](google-cloud-beyondcorp-clientgateways-v0.4.2...google-cloud-beyondcorp-clientgateways-v0.4.3)(2023-09-30)### Documentation* Minor formatting([#11630](#11630))([b176996](b176996))</details><details><summary>google-cloud-bigquery-analyticshub: 0.4.3</summary>##[0.4.3](google-cloud-bigquery-analyticshub-v0.4.2...google-cloud-bigquery-analyticshub-v0.4.3)(2023-09-30)### Features* add Subscription resource and RPCs([a18915b](a18915b))</details><details><summary>google-cloud-bigquery-connection: 1.13.2</summary>##[1.13.2](google-cloud-bigquery-connection-v1.13.1...google-cloud-bigquery-connection-v1.13.2)(2023-09-30)### Documentation* Minor formatting([#342](#342))([cda2dc6](cda2dc6))</details><details><summary>google-cloud-bigquery-datatransfer: 3.12.1</summary>##[3.12.1](google-cloud-bigquery-datatransfer-v3.12.0...google-cloud-bigquery-datatransfer-v3.12.1)(2023-09-30)### Documentation* Update transferConfig.name description to indicate that it supportsboth formats([#494](#494))([5141dc2](5141dc2))</details><details><summary>google-cloud-bigquery-reservation: 1.11.3</summary>##[1.11.3](google-cloud-bigquery-reservation-v1.11.2...google-cloud-bigquery-reservation-v1.11.3)(2023-09-30)### Documentation* Minor formatting([#377](#377))([2b8616a](2b8616a))</details><details><summary>google-cloud-contact-center-insights: 1.13.0</summary>##[1.13.0](google-cloud-contact-center-insights-v1.12.1...google-cloud-contact-center-insights-v1.13.0)(2023-09-30)### Features* add optional SpeechConfig to UploadConversationRequest([bfc25b7](bfc25b7))</details><details><summary>google-cloud-container: 2.32.0</summary>##[2.32.0](google-cloud-container-v2.31.0...google-cloud-container-v2.32.0)(2023-09-30)### Features* add SecurityPostureConfig Enterprise vuln mode to allow customers toenable Advanced Vulnerability Scanning for their clusters([#413](#413))([0280a30](0280a30))### Documentation* Minor formatting([#411](#411))([1408937](1408937))</details><details><summary>google-cloud-contentwarehouse: 0.7.2</summary>##[0.7.2](google-cloud-contentwarehouse-v0.7.1...google-cloud-contentwarehouse-v0.7.2)(2023-09-30)### Features* add matched_token_page_indices field in Document Warehouse API v1([030a767](030a767))</details><details><summary>google-cloud-datacatalog: 3.16.0</summary>##[3.16.0](google-cloud-datacatalog-v3.15.2...google-cloud-datacatalog-v3.16.0)(2023-09-30)### Features* Enable Vertex AI Ingestion on DataPlex([#11762](#11762))([b9d7b71](b9d7b71))</details><details><summary>google-cloud-dataproc-metastore: 1.13.0</summary>##[1.13.0](google-cloud-dataproc-metastore-v1.12.1...google-cloud-dataproc-metastore-v1.13.0)(2023-09-30)### Features* added EndpointLocation (v1, v1beta, v1alpha)([b254665](b254665))</details><details><summary>google-cloud-dialogflow: 2.25.0</summary>##[2.25.0](google-cloud-dialogflow-v2.24.1...google-cloud-dialogflow-v2.25.0)(2023-09-30)### Features* Add the enable_partial_automated_agent_reply flag([2996e9b](2996e9b))* Remove backend API deadline([2996e9b](2996e9b))</details><details><summary>google-cloud-dialogflow-cx: 1.28.0</summary>##[1.28.0](google-cloud-dialogflow-cx-v1.27.1...google-cloud-dialogflow-cx-v1.28.0)(2023-09-30)### Features* add Inline destination([40ee037](40ee037))* add Intent import/export APIs([40ee037](40ee037))* add support for AdvancedSettings([40ee037](40ee037))</details><details><summary>google-cloud-network-connectivity: 2.2.0</summary>##[2.2.0](google-cloud-network-connectivity-v2.1.0...google-cloud-network-connectivity-v2.2.0)(2023-09-30)### Features* add Network Connectivity Center APIs related to VPC spokes([#11769](#11769))([4cf708c](4cf708c))</details><details><summary>google-cloud-os-config: 1.15.3</summary>##[1.15.3](google-cloud-os-config-v1.15.2...google-cloud-os-config-v1.15.3)(2023-09-30)### Documentation* Minor formatting([#295](#295))([8805a43](8805a43))</details><details><summary>google-cloud-scheduler: 2.11.2</summary>##[2.11.2](google-cloud-scheduler-v2.11.1...google-cloud-scheduler-v2.11.2)(2023-09-30)### Documentation* Minor formatting([#353](#353))([951433b](951433b))</details><details><summary>google-cloud-texttospeech: 2.14.2</summary>##[2.14.2](google-cloud-texttospeech-v2.14.1...google-cloud-texttospeech-v2.14.2)(2023-09-30)### Documentation* Minor formatting([#388](#388))([c051f1b](c051f1b))</details>---This PR was generated with [ReleasePlease](https://github.com/googleapis/release-please). See[documentation](https://github.com/googleapis/release-please#release-please).---------Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Source-Link:https://togithub.com/googleapis/synthtool/commit/0ddbff8012e47cde4462fe3f9feab01fbc4cdfd6Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bced5ca77c4dda0fd2f5d845d4035fc3c5d3d6b81f245246a36aee114970082b
* feat: added VerifyConnectivity RPCPiperOrigin-RevId: 530991686Source-Link:googleapis/googleapis@be2600eSource-Link:googleapis/googleapis-gen@7eadc0eCopy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2VhZGMwZTBhYWVjZTJiY2NiNGU1NjFmM2IyOWIwNTg0ZmJjZjkwNiJ9* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md---------Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore: Update gapic-generator-python to v1.11.7PiperOrigin-RevId: 573230664Source-Link:googleapis/googleapis@93beed3Source-Link:googleapis/googleapis-gen@f4a4edaCopy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjRhNGVkYWE4MDU3NjM5ZmNmNmFkZjkxNzk4NzIyODBkMWE4ZjY1MSJ9* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* chore: Update gapic-generator-python to v1.11.8PiperOrigin-RevId: 574178735Source-Link:googleapis/googleapis@7307199Source-Link:googleapis/googleapis-gen@ce3af21Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2UzYWYyMWI3YzU1OWE4N2MyYmVmYzA3NmJlMGUzYWVkYTNhMjZmMCJ9* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md---------Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link:googleapis/synthtool@453a5d9Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:81ed5ecdfc7cac5b699ba4537376f3563f6f04122c4ec9e735d3b3dc1d43dd32
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
There need to be some changes in `google-cloud-bigquery` for thisfix:googleapis/python-bigquery#703 (comment) (Update: Done!)Closes#387
* chore: allow releases from older version branches* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.mdCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* chore: exclude requirements.txt file from renovate-botSource-Link:googleapis/synthtool@f58d313Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7a40313731a7cb1454eef6b33d3446ebb121836738dc3ab3d2d3ded5268c35b6* update constraints files* fix(deps): require protobuf 3.20.2Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* fix:Fixes#346 by reseeding for each auto id on py3.6
It is now possible to set the namespace on the context, overriding thenamespace set on the client. This makes it easier to write multi-homedapplications which might access different namespaces depending on whichuser is logged in or other variable only known at request time.`client.Client.context` has a new argument, `namespace`, which can beused to set the namespace at request time. Here is an example of youmight do this in a WSGI middleware:~~~~def ndb_wsgi_middleware(wsgi_app): client = ndb.Client() def middleware(environ, start_response): global_cache = ndb.RedisCache.from_environment() namespace = get_namespace_from_request(environ) with client.context(global_cache=global_cache, namespace=namespace): return wsgi_app(environ, start_response) return middlewareapp = flask.Flask("NDB Example")app.wsgi_app = ndb_wsgi_middleware(app.wsgi_app) # Wrap the app in middleware.~~~~Closes#385.
Pulls in the subset of
apitoolswhich#334 claims can be used to implement upload / download ingcloud.storage.key). These four modules do not usegoogle-protorpcat all.Updates the vendored-in modules to use relative imports (since they will only be used when the "real"
apitoolsis not available).Updates our CI configuration to suppress PEP8 / lint checking for the vendored code.