- Notifications
You must be signed in to change notification settings - Fork1.6k
chore(migration): Migrate code from googleapis/python-dns into packages/google-cloud-dns#14930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
parthea wants to merge306 commits intomainChoose a base branch frommigration.python-dns.migration.2025-11-24_21-55-24.migrate
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
chore(migration): Migrate code from googleapis/python-dns into packages/google-cloud-dns#14930
parthea wants to merge306 commits intomainfrommigration.python-dns.migration.2025-11-24_21-55-24.migrate
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Using `STRING_TEMPLATE % VARIABLE` can introduce hard-to-find bugsif `VARIABLE` is expected to be a string but ends up being a tuple.Instead of using percent formatting, just using `.format`.Also making tweaks to `get_target_packages` to make some pathmanipulation / checks OS-independent.
* Make clients explicitly unpickleable.Closes#3211.* Make clients explicitly unpickleable.Closes#3211.* Add GA designator, add 1.0 version numbers.* Version changes. Eep.* Oops, Speech is still alpha.* 0.24.0, not 0.24.1* Remove double __getstate__ goof.* Version changes. Eep.* Oops, Speech is still alpha.* Remove double __getstate__ goof.* Adding 3.6 classifier where missing and fixing bad versions.Done via "git grep '0\.24'" and "git grep '0\.23'".* Fix Noxfiles forlocal packages.* Fixing copy-pasta issue in error reporting nox config.Also fixing bad indent in same file.* Depend on stable logging in error reporting package.* Fixing lint errors in error_reporting.These were masked because error_reporting's lint nox sessionwas linting the datastore codebase.This also means that the error reporting package hasgained __all__.* Fixing a syntax error in nox config for logging.Also fixing an indent error while I was in there.* Revert "Add docs for 'result_index' usage and a system test."This reverts commitb5742aa.* Fixing docs nox session for umbrella package.Two issues:- error_reporting came BEFORE logging (which means it would try to pull in a logging dep from PyPI that doesn't exist)- dns was NOT in the list of local packages* Updating upper bound on logging in error_reporting.* Un-revert typo fix.
Done via:$ git grep -l author_email | \> xargs sed -i s/jjg+google-cloud-python@google.com/googleapis-publisher@google.com/gand manually editing `videointelligence/setup.py` and `vision/setup.py`.
* Fixing references to "dead" docs links.Done via:$ git grep -l 'google-cloud-auth.html' | \> xargs sed -i s/'google-cloud-auth.html'/'core\/auth.html'/g$ git grep -l 'http\:\/\/google-cloud-python.readthedocs.io' | \> xargs sed -i s/'http\:\/\/google-cloud-python.readthedocs.io'/\> 'https\:\/\/google-cloud-python.readthedocs.io'/gFixes#3531.* Fixing up other docs that were moved in#3459.
Done via$ export OLD='https\:\/\/pypi.python.org\/pypi\/'$ export NEW='https\:\/\/pypi.org\/project\/'$ git grep -l ${OLD} | xargs sed -i s/${OLD}/${NEW}/gThen manually going through and adding a trailing slash to allwarehouse links.(Though I did undo changes to `docs/json/`.)* Core: remove httplib2, replace with RequestsAdditionally remove make_exception in favor of from_http_status and from_http_response.* Datastore: replace httplib2 with Requests* DNS: replace httplib2 with Requests* Error Reporting: replace httplib2 with requests* Language: replace httplib2 with Requests* Logging: replace httplib2 with requests* Monitoring: replace httplib2 with Requests* Pubsub: replace httplib2 with Requests* Resource Manager: replace httplib2 with Requests* Runtimeconfig: replace httplib2 with Requests* Speech: replace httplib2 with Requests* Storage: replace httplib2 with Requests* BigQuery: replace httplib2 with Requests* Translate: replace httplib2 with Requests* Vision: replace httplib2 with Requests
* Updating all affected packages after google-cloud-core update.* Moving 'pip install .' **after** subpackages in nox docs.@lukesneeringer still hasn't explained why it was moved. Init's current location, the depencencies are first retrievedfrom PyPI (which fails here for the unreleased versions), e.g.https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2716
See also#3763$ sed -i '' 's/googlecloudplatform.github.io\/google-cloud-python\/stable\//googlecloudplatform.github.io\/google-cloud-python\/latest\//g' **/*.rst
* Move google.cloud.iterator to google.api.core.page_iterator* Re-write tests to pytest style.* Make GAXIterator private- it will soon be removed.* Pass api_request into HTTPIterator to avoid accessing private members* BigQuery: use google.api.core.page_iterator* DNS: use google.api.core.page_iterator* Logging: use google.api.core.page_iterator* PubSub: use google.api.core.page_iterator* Resource manager: use google.api.core.page_iterator* Runtimeconfig: use google.api.core.page_iterator* logging: use google.api.core._GAXIterator* Storage: use google.api.core.page_iterator* Pubsub: use google.api.core._GAXIterator* Trace: use google.api.core._GAXIterator* Spanner: use google.api.core._GAXIterator
- dns- error_reporting- language- logging- monitoring- resource_manager- runtimeconfig- speech- translate- visionAlso updating bounds on these in `google-cloud` uber-package.
The gcloud-common repo moved tohttps://github.com/GoogleCloudPlatform/google-cloud-common
* Remove api.core packages from google.cloud.core, make google.cloud.core depend on api_core.* s/google.api.core/google.api_core/g and nox updates* Fixing core tests, addressing review feedback* Fix bigquery
Also- updating all dependencies of `grpcio` to `>= 1.7.0`. This was due to an issue [1] with `1.6.0`.- updating the version of `google-api-core` (also to be released, This is required since the bounds on `grpcio` of `google-cloud-core==0.28.0` and `google-api-core==0.1.0` are mutually exclusive.)- Updating `google-api-core` CHANGELOG for release.- Updating packages to depend on `google-cloud-core>=0.28.0`.- Installing `nox -s lint` deps locally for vision.[1]:grpc/grpc#12455
* Making release for most packages.Every package except those that have already been released(`google-cloud-core`, `google-api-core`, `google-cloud-bigquery`):- `google-cloud`- `google-cloud-bigtable`- `google-cloud-datastore`- `google-cloud-dns`- `google-cloud-error-reporting`- `google-cloud-firestore`- `google-cloud-language`- `google-cloud-logging`- `google-cloud-monitoring`- `google-cloud-resource-manager`- `google-cloud-runtimeconfig`- `google-cloud-spanner`- `google-cloud-speech`- `google-cloud-storage`- `google-cloud-trace`- `google-cloud-translate`- `google-cloud-videointelligence`- `google-cloud-vision`* Adding changelog files for each package.
This is to make it clear the code is between releases. Any codethat relies on a **new** feature (e.g. of `google-api-core`) willthen be able to **explicitly** make this clear by using thelower bound of the `devN` version.Fixes#4208.See:https://snarky.ca/how-i-manage-package-version-numbers/
Also obeying an 80-column limit for the content andadding a missing "``virtualenv``" in the phrase"``pip`` and ``virtualenv``" in some of the docs.
* Making a `nox -s default` session for all packages.* Using "default" `nox` session on AppVeyor.This was 32-bit or 64-bit Python can be used, dependingon which is the active `python` / the active `nox.exe`.
Source-Link:googleapis/synthtool@9ae0785Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:52210e0e0559f5ea8c52be148b33504022e1faef4e95fbe4b32d68022af2fa7eCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link:googleapis/synthtool@bef813dPost-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:94bb690db96e6242b2567a4860a94d48fa48696d092e51b0884a1a2c0a79a407Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link:googleapis/synthtool@e6f91ebPost-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:365d92ef2206cfad00a8c5955c36789d0de124e2b6d92a72dd0486315a0f2e57Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link:googleapis/synthtool@71a7297Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e8dcfd7cbfd8beac3a3ff8d3f3185287ea0625d859168cc80faccfc9a7a00455Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore(python): update dependencies in .kokoro/docker/docsSource-Link:googleapis/synthtool@59171c8Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2ed982f884312e4883e01b5ab8af8b6935f0216a5a2d82928d273081fc3be562* Add constraints file for Python 3.13---------Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>Co-authored-by: Anthonios Partheniou <partheniou@google.com>
#299)Source-Link:googleapis/synthtool@de3def6Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:a1c5112b81d645f5bbc4d4bbc99d7dcb5089a52216c0e3fb1203a0eeabadd7d5Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…fig (#301)Source-Link:googleapis/synthtool@106d292Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8ff1efe878e18bd82a0fb7b70bb86f77e7ab6901fed394440b6135db0ba8d84aCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link:googleapis/synthtool@bd9ede2Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:04c35dc5f49f0f503a306397d6d043685f8d2bb822ab515818c4208d7fb2db3aCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.4 to 3.1.5.- [Release notes](https://github.com/pallets/jinja/releases)- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)- [Commits](pallets/jinja@3.1.4...3.1.5)---updated-dependencies:- dependency-name: jinja2 dependency-type: indirect...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
Bumps [virtualenv](https://github.com/pypa/virtualenv) from 20.26.3 to 20.26.6.- [Release notes](https://github.com/pypa/virtualenv/releases)- [Changelog](https://github.com/pypa/virtualenv/blob/main/docs/changelog.rst)- [Commits](pypa/virtualenv@20.26.3...20.26.6)---updated-dependencies:- dependency-name: virtualenv dependency-type: indirect...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
Source-Link:googleapis/synthtool@93e1685Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:631b4a35a4f9dd5e97740a97c4c117646eb85b35e103844dc49d152bd18694cdCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
Source-Link:googleapis/synthtool@1fb7b51Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:58dd193e1be3f5f02276cdf222ed7f8dfc3be1f163488aea767bcf35a0e2b0cdCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
Source-Link:googleapis/synthtool@d1011bcPost-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:fdc038572b896f739f95cc90e62f16c06e4f2ef0ef3bea343a358331862ad0f0Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
Source-Link:googleapis/synthtool@aa69fb7Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f016446d6e520e5fb552c45b110cba3f217bffdd3d06bdddd076e9e6d13266cfCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…stalled (#313)Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* feat: Adds Python 3.13 support* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* fix(kokoro): Preserve NOX_SESSION in presubmit.cfg* Apply suggestion from@chalmerlowe* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* fix(kokoro): Update path to presubmit.cfg in owlbot.py* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* Apply suggestion from@chalmerlowe* Apply suggestion from@chalmerlowe* Update owlbot.py* Update .kokoro/presubmit/presubmit.cfg* updates owlbot.py and noxfile.py to use 3.10 for system and linting.* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* updates owlbot.py to try to account for system test* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* Apply suggestion from@chalmerlowe* Apply suggestion from@chalmerlowe* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* Apply suggestion from@chalmerlowe* Apply suggestion from@chalmerlowe* Apply suggestion from@chalmerlowe* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* Apply suggestion from@chalmerlowe* Apply suggestion from@chalmerlowe* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* Apply suggestion from@chalmerlowe* updates lint version to match default of 3.10* updates system test version to match default of 3.10* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* updates lint version to match default of 3.10 redux* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* modified the owlbot to take advantage of a capability in common.py_library* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md---------Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* updates trove classifier* feat: Add constraints file for Python 3.14* ci: Add Python 3.14 to GitHub Actions workflow* fix(kokoro): Preserve NOX_SESSION in presubmit.cfg* feat(ci): Add Python 3.14 support* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* ci: Re-add Python 3.14 to unittest matrix* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* fix(owlbot): Use kwargs to control python versions in templates* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* fix(owlbot): Ensure noxfile.py skips cpp impl for 3.14* Apply suggestion from@chalmerlowe* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* Apply suggestion from@chalmerlowe* Apply suggestion from@chalmerlowe* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md---------Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* test: ignore Python 3.10 FutureWarning* correct regex* regex* also ignore DeprecationWarning for python 3.8* regex* regex* add 3.9
Source-Link:googleapis/synthtool@6702a34Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:fbbc8db67afd8b7d71bf694c5081a32da0c528eba166fbcffb3b6e56ddf907d5Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
* test: remove python 3.7 and 3.8 from noxfile unit tests* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* undo owlbot change* add owlbot string replacement* correct regex* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* correct regex* modify noxfile---------Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop*---##[0.36.0](googleapis/python-dns@v0.35.1...v0.36.0)(2025-11-05)### Features* Add support for Python 3.14([#321](googleapis/python-dns#321))([99c0adb](googleapis/python-dns@99c0adb))* Adds Python 3.13 support([#319](googleapis/python-dns#319))([ea851ce](googleapis/python-dns@ea851ce))---This PR was generated with [ReleasePlease](https://github.com/googleapis/release-please). See[documentation](https://github.com/googleapis/release-please#release-please).Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Towardsgoogleapis/librarian#2454---------Co-authored-by: ohmayr <omairn@google.com>
… migration.python-dns.migration.2025-11-24_21-55-24.migrate
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See#11024.
This PR should be merged with a merge-commit, not a squash-commit, in order to preserve the git history.