- Notifications
You must be signed in to change notification settings - Fork1.6k
fix(bigquery): fix inserting missing repeated fields#10196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
plamut commentedJan 24, 2020
The failing snippets test is unrelated,#10195 will fix it, |
plamut commentedJan 29, 2020
The unit tests failure will be fixed in#10222. |
plamut commentedJan 30, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Weird, a couple of PermissionDenied errors in system tests. Re-running the jobs. Update: I cannot reproduce this locally, neither on the PR branch, nor on on the latest |
tswast left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One nit, otherwise LGTM
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#9602.
This PR fixes the issue when inserting rows with missing REPEATED fields. Omitting a REPEATED field from the request does not result in an error anymore.
How to test
Best to run the ready-made script from one of theissue comments.
MIND:
Omitting
Nonevalues only happens when the code needs to convert the data to JSON by itself, i.e. ininsert_rows(). The following thus still fails wheninsert_rows_json()is used:If this inconsistency is not desired, we need to sync the logic in these two methods.
PR checklist