Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(bigquery): fix inserting missing repeated fields#10196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
plamut merged 4 commits intogoogleapis:masterfromplamut:iss-9602
Jan 31, 2020

Conversation

@plamut
Copy link
Contributor

@plamutplamut commentedJan 24, 2020
edited
Loading

Fixes#9602.

This PR fixes the issue when inserting rows with missing REPEATED fields. Omitting a REPEATED field from the request does not result in an error anymore.

How to test

Best to run the ready-made script from one of theissue comments.

MIND:
OmittingNone values only happens when the code needs to convert the data to JSON by itself, i.e. ininsert_rows(). The following thus still fails wheninsert_rows_json() is used:

rows= [{"int_col":9,"repeated_col":None}errors=client.insert_rows_json(TABLE_PATH,rows)

If this inconsistency is not desired, we need to sync the logic in these two methods.

PR checklist

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamutplamut added the api: bigqueryIssues related to the BigQuery API. labelJan 24, 2020
@plamutplamut requested review froma team andtswastJanuary 24, 2020 12:09
@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement. labelJan 24, 2020
@plamut
Copy link
ContributorAuthor

The failing snippets test is unrelated,#10195 will fix it,

@plamutplamut added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelJan 29, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelJan 29, 2020
@plamut
Copy link
ContributorAuthor

The unit tests failure will be fixed in#10222.

@plamutplamut added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelJan 30, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelJan 30, 2020
@plamutplamut added the kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelJan 30, 2020
@yoshi-kokoroyoshi-kokoro removed kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsJan 30, 2020
@plamut
Copy link
ContributorAuthor

plamut commentedJan 30, 2020
edited
Loading

Weird, a couple of PermissionDenied errors in system tests. Re-running the jobs.

Update: I cannot reproduce this locally, neither on the PR branch, nor on on the latestmaster. Hmm...

Copy link
Contributor

@tswasttswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One nit, otherwise LGTM

@plamutplamut merged commitf0bcbd6 intogoogleapis:masterJan 31, 2020
@plamutplamut deleted the iss-9602 branchJanuary 31, 2020 08:18
This was referencedJan 31, 2020
This was referencedFeb 2, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tswasttswasttswast approved these changes

Assignees

No one assigned

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery: insert_rows() fails when a repeated field is missing

4 participants

@plamut@tswast@googlebot@yoshi-kokoro

[8]ページ先頭

©2009-2025 Movatter.jp