- Notifications
You must be signed in to change notification settings - Fork1.6k
feat(bigquery): check rows arg type in insert_rows()#10174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| ValueError: if table's schema is not set or `rows` is not a `Sequence`. | ||
| """ | ||
| ifnotisinstance(rows, (collections_abc.Sequence,collections_abc.Iterator)): | ||
| raiseTypeError("rows argument should be a sequence of dicts or tuples") |
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
AddingIterator too asinsert_rows_from_dataframe() callsinsert_rows() with iterator returned byitertools.islice.dict still will give aFalse at this statement
tswast approved these changesJan 23, 2020
This was referencedJan 29, 2020
Merged
Merged
This was referencedJan 29, 2020
Merged
chore(websecurityscanner): bump copyright year to 2020, tweak docstring formatting (via synth)#10243
Merged
Closed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
api: bigqueryIssues related to the BigQuery API. cla: yesThis human has signed the Contributor License Agreement. type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Continuation of#10162
Adding arg type check into
insert_rows()method