Commitbbe686d

authored

Use configurable bucket name for GCS samples data in systems tests. (#8783)

* Use configurable bucket name for GCS samples data in systems tests.This allows the VPC-SC team to use their private mirror which is withinthe security boundary when testing BigQuery VPC-SC support.* Blacken

1 parentb32e4e9 commitbbe686dCopy full SHA for bbe686d

File tree

1 file changed

-1

lines changed

bigquery/tests
- system.py

1 file changed

-1

lines changed

`‎bigquery/tests/system.py‎`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,11 @@`
`107`	`107`	`),`
`108`	`108`	`]`
`109`	`109`
	`110`	`+# The VPC-SC team maintains a mirror of the GCS bucket used for code`
	`111`	`+# samples. The public bucket crosses the configured security boundary.`
	`112`	`+# See: https://github.com/googleapis/google-cloud-python/issues/8550`
	`113`	`+SAMPLES_BUCKET=os.environ.get("GCLOUD_TEST_SAMPLES_BUCKET","cloud-samples-data")`
	`114`	`+`
`110`	`115`	`retry_storage_errors=RetryErrors(`
`111`	`116`	`(TooManyRequests,InternalServerError,ServiceUnavailable)`
`112`	`117`	`)`
`@@ -1877,7 +1882,9 @@ def test_create_routine(self):`
`1877`	`1882`	`language="JAVASCRIPT",`
`1878`	`1883`	`type_="SCALAR_FUNCTION",`
`1879`	`1884`	`return_type=float64_type,`
`1880`		`-imported_libraries=["gs://cloud-samples-data/bigquery/udfs/max-value.js"],`
	`1885`	`+imported_libraries=[`
	`1886`	`+"gs://{}/bigquery/udfs/max-value.js".format(SAMPLES_BUCKET)`
	`1887`	`+ ],`
`1881`	`1888`	`)`
`1882`	`1889`	`routine.arguments= [`
`1883`	`1890`	`bigquery.RoutineArgument(`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbbe686d

File tree

1 file changed

1 file changed

`‎bigquery/tests/system.py‎`

0 commit comments