Commit63699a9

authored

docs: update move logic now to support non-HNS buckets (#8705)

1 parent4a9423c commit63699a9Copy full SHA for 63699a9

File tree

2 files changed

+13

-5

lines changed

Storage
- src
  - StorageObject.php
- tests/System
  - ManageObjectsTest.php

2 files changed

+13

-5

lines changed

`‎Storage/src/StorageObject.php‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -478,7 +478,7 @@ public function rewrite($destination, array $options = [])`
`478`	`478`	`}`
`479`	`479`
`480`	`480`	`/**`
`481`		`- * Move an object within a bucket with HNS enabled.`
	`481`	`+ * Move an object within a bucket.`
`482`	`482`	`*`
`483`	`483`	`* This method copies data using multiple requests so large objects can be`
`484`	`484`	`* copied with a normal length timeout per request rather than one very long`

`‎Storage/tests/System/ManageObjectsTest.php‎`

Lines changed: 12 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -357,7 +357,10 @@ public function testSoftDeleteHNSObject()`
`357`	`357`	`$this->assertStorageObjectExists($softDeleteHNSBucket,$restoredObject);`
`358`	`358`	`}`
`359`	`359`
`360`		`-publicfunctiontestMoveObject()`
	`360`	`+/**`
	`361`	`+ * @dataProvider provideMoveObject`
	`362`	`+ */`
	`363`	`+publicfunctiontestMoveObject(bool$hnEnabled)`
`361`	`364`	`{`
`362`	`365`	`$name ="move-object-bucket-" .uniqid();`
`363`	`366`	`$sourceObjectName =uniqid(self::TESTING_PREFIX);`
`@@ -366,7 +369,7 @@ public function testMoveObject()`
`366`	`369`	`self::$client,`
`367`	`370`	`$name,`
`368`	`371`	`[`
`369`		`-'hierarchicalNamespace' => ['enabled' =>true,],`
	`372`	`+'hierarchicalNamespace' => ['enabled' =>$hnEnabled],`
`370`	`373`	`'iamConfiguration' => ['uniformBucketLevelAccess' => ['enabled' =>true]]`
`371`	`374`	`]`
`372`	`375`	`);`
`@@ -380,12 +383,17 @@ public function testMoveObject()`
`380`	`383`	`// Move the object.`
`381`	`384`	`$movedObject =$object->move($destinationObjectName);`
`382`	`385`
`383`		`-// Assert that checkexistance of source and destination object.`
	`386`	`+// Assert that checkexistence of source and destination object.`
`384`	`387`	`$this->assertStorageObjectNotExists($sourceBucket,$object);`
`385`	`388`	`$this->assertStorageObjectExists($sourceBucket,$movedObject);`
`386`	`389`	`}`
`387`	`390`
`388`		`-publicfunctiontestRotatesCustomerSuppliedEncrpytion()`
	`391`	`+publicfunctionprovideMoveObject()`
	`392`	`+ {`
	`393`	`+return [[true], [false]];`
	`394`	`+ }`
	`395`	`+`
	`396`	`+publicfunctiontestRotatesCustomerSuppliedEncryption()`
`389`	`397`	`{`
`390`	`398`	`$key =base64_encode(openssl_random_pseudo_bytes(32));`
`391`	`399`	`$options = [`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit63699a9

File tree

2 files changed

2 files changed

`‎Storage/src/StorageObject.php‎`

`‎Storage/tests/System/ManageObjectsTest.php‎`

0 commit comments