- Notifications
You must be signed in to change notification settings - Fork1.1k
Add RemoteBigQueryHelper and integration tests#492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- Add RemoteBigQueryHelper to help writing tests against BigQuery (with docs and tests)- Add integration tests (ITBigQueryTest- Add gcloud-java-storage as a test dependency- Update bigquery dependency
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
aozarov commentedDec 19, 2015
Looks good. few comments. |
- Remove RemoteBigQueryHelper.create(String, String)- Add javadoc to RemoteBigQueryHelper to document retry options- Add global timeout of 5minutes to each of the BigQuery ITs- Remove print from BigQueryImplTest and other nits
mziccard commentedDec 21, 2015
Comments addresses, what is related to storage will come in a separate PR later today |
Add RemoteBigQueryHelper and integration tests
🤖 I have created a release *beep* *boop*---### Updating meta-information for bleeding-edge SNAPSHOT release.---This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Making CLIRR not required. The version bumps are now controlled by the Release Please and OwlBot. The CL authors create appropriate change description to control major version bumps.
…-info-reports-plugin to v3.4.0 (#492)[](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.3.0` -> `3.4.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) |---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this update again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-retail).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTcuNCIsInVwZGF0ZWRJblZlciI6IjMyLjExNy40In0=-->
…s to v2.3.3 (#492)[](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [com.google.cloud:google-cloud-workflows](https://togithub.com/googleapis/java-workflows) | `2.3.2` -> `2.3.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) |---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.---This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-workflows).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTQuMyIsInVwZGF0ZWRJblZlciI6IjMyLjE5NC4zIn0=-->
🤖 I have created a release *beep* *boop*---## [0.13.5](https://togithub.com/googleapis/java-analytics-admin/compare/v0.13.4...v0.13.5) (2022-10-05)### Bug Fixes* update protobuf to v3.21.7 ([68a6a94](https://togithub.com/googleapis/java-analytics-admin/commit/68a6a9412103c1e8fe872200ffc5535a3dd4e2a0))---This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
…workloads to v2.3.0 (#492)[](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [com.google.cloud:google-cloud-assured-workloads](https://togithub.com/googleapis/java-assured-workloads) ([source](https://togithub.com/googleapis/java-)) | `2.2.1` -> `2.3.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) |---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.---This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-assured-workloads).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTcuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxNy4wIn0=-->
…492)[](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [com.google.cloud:google-iam-policy](https://togithub.com/googleapis/java-eventarc) ([source](https://togithub.com/googleapis/java-iam)) | `1.6.5` -> `1.6.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) |---### Release Notes<details><summary>googleapis/java-iam</summary>### [`v1.6.6`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#​166-httpsgithubcomgoogleapisjava-iamcomparev165v166-2022-10-25)[Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.6.5...v1.6.6)##### Dependencies- Update dependency com.google.cloud:google-iam-policy to v1.6.5 ([#​489](https://togithub.com/googleapis/java-iam/issues/489)) ([558cafc](https://togithub.com/googleapis/java-iam/commit/558cafcfc10c7465465499e6df28c66afd57f6bf))</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this update again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.---This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDEuMTEiLCJ1cGRhdGVkSW5WZXIiOiIzMi4yNDEuMTEifQ==-->
🤖 I have created a release *beep* *boop*---## [1.6.7](https://togithub.com/googleapis/java-iam/compare/v1.6.6...v1.6.7) (2022-10-31)### Dependencies* Update dependency com.google.api:api-common to v2.2.2 ([#497](https://togithub.com/googleapis/java-iam/issues/497)) ([0cb8ba7](https://togithub.com/googleapis/java-iam/commit/0cb8ba78d5c07b64570c65ce14d61db5f08150a8))* Update dependency com.google.cloud:google-iam-policy to v1.6.6 ([#492](https://togithub.com/googleapis/java-iam/issues/492)) ([bad1c9b](https://togithub.com/googleapis/java-iam/commit/bad1c9b58c4a76017d3665a3ef0887c3481b35e8))* Update dependency com.google.http-client:google-http-client-jackson2 to v1.42.3 ([#498](https://togithub.com/googleapis/java-iam/issues/498)) ([b68ed60](https://togithub.com/googleapis/java-iam/commit/b68ed601d723dd235dc21e28b22035860a04e6e0))* Update dependency com.google.protobuf:protobuf-bom to v3.21.9 ([#495](https://togithub.com/googleapis/java-iam/issues/495)) ([2462317](https://togithub.com/googleapis/java-iam/commit/2462317d386a59d07a85c8a752371a09635aa86f))* Update dependency com.google.protobuf:protobuf-java to v3.21.9 ([#493](https://togithub.com/googleapis/java-iam/issues/493)) ([160b427](https://togithub.com/googleapis/java-iam/commit/160b427f55f8f8ee4d27ba2c5d2d00664d088ff9))---This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This PR does the following
RemoteBigQueryHelperto help writing tests against BigQuery (with docs and tests)ITBigQueryTest)gcloud-java-storageas a test dependencyRemarks: integration tests might take long to execute depending on how long it takes for jobs to complete. I decided to push them anyway and see how long they take, if we see that they take too much we can avoid merging or remove the tests that involve longer jobs (load?)