- Notifications
You must be signed in to change notification settings - Fork433
fix(generator): include API version in client docs#15841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello@noahdietz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the generated client documentation by embedding the Highlights
🧠New Feature in Public Preview: You can now enableMemory to helpGemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style.Clickhere to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code Review
This pull request adds the API version to the generated client documentation comments, which is a useful piece of information for users of the client library. The implementation looks mostly correct, but I have a suggestion to improve the formatting of the generated comment for better readability.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
noahdietz commentedDec 18, 2025
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code Review
This pull request aims to include the API version in the generated client documentation, which is a helpful addition for users to reference. The implementation is straightforward, but I've found a minor formatting issue where an extra blank line is introduced in the generated comments. I've provided a suggestion to correct this, which should result in cleaner and more consistent documentation.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #15841 +/- ##==========================================+ Coverage 92.94% 92.95% +0.01%========================================== Files 2458 2458 Lines 227585 227588 +3 ==========================================+ Hits 211531 211565 +34+ Misses 16054 16023 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds simple breadcrumb comment to client class commentary including the
google.api.api_versionvalue that this client was generated based on and sends in its requests, as perAIP-4236. This breadcrumb will allow client users to reference the API version used by the client in other API artifacts e.g. product documentation.Fixes internal tracking bughttp://b/467139856, child ofhttp://b/467065424.