- Notifications
You must be signed in to change notification settings - Fork433
API Implementation for ResumeAppendableObjectUpload#15816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Summary of ChangesHello@rajeevpodar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a new asynchronous API, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code Review
This pull request introduces a new overload forResumeAppendableObjectUpload that accepts agoogle::storage::v2::BidiWriteObjectRequest, enhancing the API's flexibility. The implementation is sound and includes a corresponding test case. My review focuses on an opportunity to refactor duplicated code for better maintainability and a minor documentation consistency fix.
google/cloud/storage/async/client.h Outdated
| * @param opts options controlling the behaviour of this RPC, for example the | ||
| * application may change the retry policy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There's a spelling inconsistency. This comment uses "behaviour" (British English), but other comments in this file and codebase use "behavior" (American English). For consistency, it's best to use one spelling throughout the project.
* @paramoptsoptionscontrollingthebehaviorofthisRPC,forexamplethe*applicationmaychangetheretrypolicy.
codecovbot commentedDec 5, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #15816 +/- ##==========================================- Coverage 92.95% 92.94% -0.01%========================================== Files 2458 2458 Lines 227589 227628 +39 ==========================================+ Hits 211559 211575 +16- Misses 16030 16053 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ppendableObjectUpload` overload.
| * recovery from transient failures. | ||
| * | ||
| * @param request the request contents, it must include the bucket name, | ||
| * object name, and generation. Many other fields are optional. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Forgot to mention, append_object_spec is required, write_object_spec would not work here.
Uh oh!
There was an error while loading.Please reload this page.
This PR adds a new overload for
ResumeAppendableObjectUploadthat accepts agoogle::storage::v2::BidiWriteObjectRequest. This allows callers to set specific options on the request, such asflush: true, which were previously inaccessible via the existing overload.The existing
ResumeAppendableObjectUploadoverload has been refactored to delegate to this new overload, ensuring consistent behavior and reducing code duplication.