This PR modifies the client library to send the x-goog-hash header, containing crc32c= and/or md5= values, if available, when sending the final chunk of a resumable upload.

Implementation Details
The core of the change involves coordinating hash calculation between the ObjectWriteStreambuf and the RestStub. The hash_function within ObjectWriteStreambuf maintains the running checksum state for the entire upload.

RestStub::UploadChunk:
For intermediate chunks (when last_chunk() is false), UploadChunk receives a valid hash_function_ptr from ObjectWriteStreambuf. It calls hash_function->Update() to incorporate the chunk's payload into the running checksum.
For the final chunk (when last_chunk() is true), UploadChunk receives a nullptr for hash_function_ptr but receives the final, computed object hashes via request.known_object_hashes(). It then adds the x-goog-hash header(s) to the HTTP request using these final hashes.

ObjectWriteStreambuf::FlushFinal:
This method is called when Close() is invoked on the stream.
It first calls hash_function->Update() with any data still pending in its internal buffer.

v-pratap requested review froma team ascode owners

December 4, 2025 05:41

v-pratap had a problem deploying to external

December 4, 2025 05:41

— with

GitHub Actions Error

product-auto-labelbot added the api: storageIssues related to the Cloud Storage API. label

Dec 4, 2025

Copy link

gemini-code-assistbot commentedDec 4, 2025

Summary of Changes

Hello@v-pratap, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Google Cloud Storage client library by implementing full object checksum validation for resumable uploads. It introduces mechanisms to calculate and transmitcrc32c andmd5 checksums in thex-goog-hash HTTP header during the finalization step of an upload, thereby bolstering data integrity and reliability for large object transfers.

Highlights

Checksum Header Integration: The client library now sendsx-goog-hash headers containingcrc32c and/ormd5 values with the final chunk of resumable uploads, enhancing data integrity.
Hash Calculation Coordination: Hash calculation logic is coordinated betweenObjectWriteStreambuf andRestStub, ensuring that the final, computed object hashes are correctly passed and included in the HTTP request.
Enhanced Test Coverage: Comprehensive unit tests have been added to verify the correct behavior of hash computation, passing, and header inclusion for various scenarios, including intermediate and final chunks, and different combinations ofcrc32c andmd5.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.

Footnotes

Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.↩

gemini-code-assistbot reviewed

Dec 4, 2025

View reviewed changes

Copy link

gemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request adds support for sending object checksums (CRC32C and MD5) in the final chunk of a resumable upload for the JSON/REST transport. The changes look good and are well-tested. I've found a couple of minor issues related to leftover debugging code that should be addressed before merging.