Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(storage): take async client out of experimental#15573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bajajneha27 wants to merge5 commits intogoogleapis:main
base:main
Choose a base branch
Loading
frombajajneha27:397946081

Conversation

@bajajneha27
Copy link
Contributor

@bajajneha27bajajneha27 commentedSep 29, 2025•
edited by scotthart
Loading

This change is Reviewable

@codecov
Copy link

codecovbot commentedOct 1, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is96.35036% with15 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.09%. Comparing base (8c2b376) to head (14d53d1).
⚠️ Report is 60 commits behind head on main.

Files with missing linesPatch %Lines
...le/cloud/storage/examples/storage_async_samples.cc83.01%9 Missing⚠️
...le/cloud/storage/internal/async/connection_impl.cc87.17%5 Missing⚠️
google/cloud/storage/testing/mock_resume_policy.h0.00%1 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main   #15573      +/-   ##==========================================- Coverage   93.10%   93.09%   -0.01%==========================================  Files        2418     2418                Lines      222268   222232      -36     ==========================================- Hits       206934   206897      -37- Misses      15334    15335       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bajajneha27bajajneha27 marked this pull request as ready for reviewOctober 1, 2025 14:24
@bajajneha27bajajneha27 requested review froma team ascode ownersOctober 1, 2025 14:24
shubham-up-47
shubham-up-47 previously approved these changesOct 7, 2025
return connection_
->Open({std::move(spec),
internal::MergeOptions(std::move(opts), connection_->options())})
->Open({std::move(spec),google::cloud::internal::MergeOptions(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why are we writing full namespace now?

Copy link
Contributor

@shubham-up-47shubham-up-47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please searchexperimental andgcs_ex keywords in your local repo, so that we don't miss these words in any file.

Please fix the code coverage which are affected by these changes.

@bajajneha27bajajneha27 added the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelOct 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@shubham-up-47shubham-up-47shubham-up-47 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

api: storageIssues related to the Cloud Storage API.do not mergeIndicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bajajneha27@shubham-up-47
[8]ページ先頭
©2009-2025 Movatter.jp