Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(storage): Support read_all in the async client#15303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
shubham-up-47 wants to merge10 commits intogoogleapis:main
base:main
Choose a base branch
Loading
fromshubham-up-47:implement_read_all

Conversation

@shubham-up-47
Copy link
Contributor

@shubham-up-47shubham-up-47 commentedJul 23, 2025•
edited
Loading

The PR fixes issue:#15140 which says to provide a function to convertstorage_experimental::AsyncReader into a singlefuture<StatusOr<ReadPayload>>. The functionality is already there instorage_experimental::ReadAll() method.

This PR adds the method to a public header i.e. async client and updates the documentation.

This change is Reviewable

@shubham-up-47shubham-up-47 requested review froma team ascode ownersJuly 23, 2025 09:49
@product-auto-labelproduct-auto-labelbot added the api: storageIssues related to the Cloud Storage API. labelJul 23, 2025
@codecov
Copy link

codecovbot commentedJul 23, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is99.08257% with1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.02%. Comparing base (c7d96c9) to head (7fd64bc).
⚠️ Report is 65 commits behind head on main.

Files with missing linesPatch %Lines
google/cloud/storage/async/client.cc94.44%1 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main   #15303      +/-   ##==========================================- Coverage   93.02%   93.02%   -0.01%==========================================  Files        2403     2403                Lines      219424   219533     +109     ==========================================+ Hits       204128   204228     +100- Misses      15296    15305       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shubham-up-47
Copy link
ContributorAuthor

/gcbrun

1 similar comment
@shubham-up-47
Copy link
ContributorAuthor

/gcbrun

@shubham-up-47
Copy link
ContributorAuthor

/gcbrun

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@bajajneha27bajajneha27Awaiting requested review from bajajneha27

1 more reviewer

@devbwwdevbwwdevbww left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

api: storageIssues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shubham-up-47@devbww
[8]ページ先頭
©2009-2025 Movatter.jp