Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: create impersonated service credentials#499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@viacheslav-rostovtsev
Copy link
Member

feat: create impersonated service credentials
feat: add duplication mechanism to various credentials to support "re-scoping" them for IAM requests

@viacheslav-rostovtsevviacheslav-rostovtsevforce-pushed thedev/virost/impersonated_creds branch 3 times, most recently from743091e to2ed3089CompareNovember 11, 2024 23:05
Copy link
Contributor

@dazumadazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

General question: what kind(s) of credentials are acceptable base credentials for these impersonated credentials? Is it just service account creds, or does it include compute engine creds, or external creds?

@viacheslav-rostovtsevviacheslav-rostovtsev added the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelDec 26, 2024
@viacheslav-rostovtsev
Copy link
MemberAuthor

Do not merge: the case where the source credentials are wrapped in the Google::Auth::Credentials is not covered

@viacheslav-rostovtsevviacheslav-rostovtsev removed the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelJan 8, 2025
client:@client,
project_id:@project_id,
quota_project_id:@quota_project_id,
logger:@logger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this should be@client.logger?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There was a giant copy paste error in credentials and I forgot to add tests. Fixed now

Copy link
Contributor

@dazumadazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just a couple more questions.

@viacheslav-rostovtsevviacheslav-rostovtsev merged commit96f5058 intogoogleapis:mainJan 22, 2025
10 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@dazumadazumadazuma approved these changes

Reviewers whose approvals may not affect merge requirements

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@viacheslav-rostovtsev@dazuma@aandreassa
[8]ページ先頭
©2009-2025 Movatter.jp