- Notifications
You must be signed in to change notification settings - Fork345
chore: rename _refresh_token to _perform_refresh_token#1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello@daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical naming conflict within the codebase by systematically renaming an internal method and a related variable. The Highlights
🧠New Feature in Public Preview: You can now enableMemory to helpGemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style.Clickhere to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code Review
This pull request is a refactoring to rename the internal_refresh_token method to_perform_refresh_token across the codebase. This change aims to resolve ambiguity where_refresh_token was used as both a method name and a variable name for a token value. The changes are generally correct and consistently applied. However, I found a critical typo in an error message that should be corrected.
Uh oh!
There was an error while loading.Please reload this page.
| request,self._refresh_token,"refresh_token",self._revoke_url | ||
| ) | ||
| self.token=None | ||
| self._refresh_token=None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This appears to be a bug in the previous code. I think this was supposed to beself._refresh_token_val.
This PR should fix any issue here though
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
A recent change added an internal _refresh_token method to some credentials files.
Parts of the codebase were already using
_refresh_tokenas an internal variable, holding a token valueThis causes some inconsistencies in the codebase, where it's not always clear if
_refresh_tokenis referring to an action or an objectIt was also causing complications in internal code that depended on _refresh_token objects
This PR renames the methods to
_perform_refresh_token, to avoid the duplicate naming