Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: rename _refresh_token to _perform_refresh_token#1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
daniel-sanche wants to merge3 commits intomain
base:main
Choose a base branch
Loading
fromrename_refresh

Conversation

@daniel-sanche
Copy link
Collaborator

A recent change added an internal _refresh_token method to some credentials files.

Parts of the codebase were already using_refresh_token as an internal variable, holding a token value

This causes some inconsistencies in the codebase, where it's not always clear if_refresh_token is referring to an action or an object

It was also causing complications in internal code that depended on _refresh_token objects

This PR renames the methods to_perform_refresh_token, to avoid the duplicate naming

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello@daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical naming conflict within the codebase by systematically renaming an internal method and a related variable. The_refresh_token method, responsible for performing the token refresh operation, has been renamed to_perform_refresh_token to clearly distinguish it from instances where_refresh_token referred to the token value itself. This refactoring significantly enhances code clarity, reduces ambiguity, and prevents potential issues stemming from overloaded naming conventions, leading to a more maintainable and understandable codebase.

Highlights

  • Method Renaming: The internal_refresh_token method has been consistently renamed to_perform_refresh_token across multiple credentials classes. This change clarifies its role as an action rather than a data attribute.
  • Variable Renaming: Ingoogle/auth/external_account_authorized_user.py, the internal attribute_refresh_token_val has been renamed to_refresh_token. This aligns its naming with the new convention and removes redundancy.
  • Improved Code Clarity: These renames resolve a naming conflict where_refresh_token was ambiguously used for both a method (an action) and a variable (a token value). This refactoring enhances readability and prevents potential complications arising from overloaded names.

🧠New Feature in Public Preview: You can now enableMemory to helpGemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style.Clickhere to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.

Footnotes

  1. Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.

Copy link
Contributor

@gemini-code-assistgemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request is a refactoring to rename the internal_refresh_token method to_perform_refresh_token across the codebase. This change aims to resolve ambiguity where_refresh_token was used as both a method name and a variable name for a token value. The changes are generally correct and consistently applied. However, I found a critical typo in an error message that should be corrected.

request,self._refresh_token,"refresh_token",self._revoke_url
)
self.token=None
self._refresh_token=None
Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This appears to be a bug in the previous code. I think this was supposed to beself._refresh_token_val.

This PR should fix any issue here though

daniel-sancheand others added2 commitsDecember 19, 2025 15:43
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@daniel-sanche

[8]ページ先頭

©2009-2025 Movatter.jp