Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: replace deprecated utcfromtimestamp#1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
andriawang6 wants to merge3 commits intogoogleapis:main
base:main
Choose a base branch
Loading
fromandriawang6:replace-utcfromtimestamp

Conversation

@andriawang6
Copy link

@andriawang6andriawang6 commentedJul 30, 2025
edited
Loading

addresses#1781

@andriawang6andriawang6force-pushed thereplace-utcfromtimestamp branch from687ac1a to250f015CompareJuly 30, 2025 00:58
@andriawang6andriawang6 marked this pull request as ready for reviewJuly 30, 2025 01:06
@andriawang6andriawang6 requested review froma team ascode ownersJuly 30, 2025 01:06
@gkevinzhenggkevinzheng requested a review froma team as acode ownerDecember 17, 2025 19:26
gkevinzheng
gkevinzheng previously approved these changesDec 17, 2025
@gkevinzhenggkevinzheng changed the titlereplace deprecated utcfromtimestampfix: replace deprecated utcfromtimestampDec 17, 2025
@partheaparthea added kokoro:force-runAdd this label to force Kokoro to re-run the tests. kokoro:runAdd this label to force Kokoro to re-run the tests. labelsDec 17, 2025
@yoshi-kokoroyoshi-kokoro removed kokoro:runAdd this label to force Kokoro to re-run the tests. kokoro:force-runAdd this label to force Kokoro to re-run the tests. labelsDec 17, 2025
@gkevinzhenggkevinzhengenabled auto-merge (squash)December 17, 2025 19:35
@partheaparthea added the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelDec 17, 2025
@partheaparthea self-assigned thisDec 17, 2025
@gkevinzhenggkevinzheng dismissed theirstale reviewDecember 18, 2025 15:34

Failing tests due to not strippingtzinfo

@gkevinzheng
Copy link
Contributor

gkevinzheng commentedDec 18, 2025
edited
Loading

Hi@andriawang6,

I don't think you can simply replaceutcfromtimestamp withfromtimestamp(tz=datetime.timezone.utc) sinceutcfromtimestamp is not offset aware, whereasfromtimestamp is. This causes issues with comparing timestamps. We've resolved a similar issue in the past (seethis discussion) by adding a.replace(tzinfo=None) after creating the timestamp object withfromtimestamp(tz=datetime.timezone.utc). You can add it togoogle/auth/_helpers.py like we did the function definition forutcnow

Also see this PR:#1413

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@partheapartheaparthea approved these changes

@gkevinzhenggkevinzhenggkevinzheng left review comments

Assignees

@partheaparthea

Labels

do not mergeIndicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andriawang6@gkevinzheng@parthea@yoshi-kokoro

[8]ページ先頭

©2009-2025 Movatter.jp