- Notifications
You must be signed in to change notification settings - Fork345
Refactor: test_jwt.py fully modularized with mock jwt.encode + expiry simulation#1726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
cureprotocols wants to merge17 commits intogoogleapis:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Refactor: test_jwt.py fully modularized with mock jwt.encode + expiry simulation#1726
cureprotocols wants to merge17 commits intogoogleapis:mainfromcureprotocols:refactor/test_jwt-complete
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Swapped from reStructuredText to Markdown for improved readability, badge support, and contributor clarity.This version of the README:- Retains full respect and gratitude for the original authors.- Clarifies project goals and roadmap.- Adds visual indicators for project health and openness to contributors.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View thisfailed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a full refactor of
tests/test_jwt.pywith the following enhancements:✅ Split into clean, modular sections:
exp,nbf,iatwithfreezegun✅ Introduced smart
dummy_encode()to simulatejwt.encode()behaviorexpandnbftime validation✅ All 15 tests pass using local fixtures and mocks (no external crypto or network dependency)
This refactor improves test clarity, modularity, and CI reliability.
Next steps can include real JWT plug-in,
test_identity_pool.pyrefactor, or CI wiring.