googleapis/google-auth-library-pythonPublic

NotificationsYou must be signed in to change notification settings
Fork345
Star864

chore: Migrate from mock to unittest.mock#1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

clundin25 wants to merge5 commits intogoogleapis:main

base:main

Choose a base branch

fromclundin25:mock-update

Open

chore: Migrate from mock to unittest.mock#1361

clundin25 wants to merge5 commits intogoogleapis:mainfromclundin25:mock-update

Conversation

Copy link

Contributor

clundin25 commentedJul 25, 2023

chore: Use stdlib unittest.mock instead of separate mock library.Resolvesuse unittest.mock instead of mock #1055
Fix mypy error.

clundin25 added2 commits

July 25, 2023 14:10

chore: Use stdlib unittest.mock instead of separate mock library.Res…

9b26950

…olvesgoogleapis#1055

Fix mypy error.

c159ebe

clundin25 requested review froma team ascode owners

July 25, 2023 21:52

BigTailWolf approved these changes

Jul 25, 2023

View reviewed changes

Copy link

Contributor

BigTailWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great! One less dependency

Run formatter

0aa60ea

Copy link

ContributorAuthor

clundin25 commentedJul 26, 2023

Looks likemock.AsyncMock is gated by Python 3.8.

I'm considering if we should just gate the Async code to 3.8 in that case, since it's still in "Preview".

@sai-sunder-s @arithmetic1728 @BigTailWolf thoughts?

Copy link

Contributor

BigTailWolf commentedJul 31, 2023

Looks likemock.AsyncMock is gated by Python 3.8.
I'm considering if we should just gate the Async code to 3.8 in that case, since it's still in "Preview".
@sai-sunder-s @arithmetic1728 @BigTailWolf thoughts?

Do we currently have anyfrom unittest.mock import AsyncMock in any test?
I searched across ed the repo and didn't see one of them.

Copy link

ContributorAuthor

clundin25 commentedJul 31, 2023

@BigTailWolf It's found in the following files:

❯ rg"AsyncMock" -ltests_async/oauth2/test__client_async.pytests_async/oauth2/test_id_token.pytests_async/oauth2/test_reauth_async.pytests_async/oauth2/test_service_account_async.pytests_async/oauth2/test_credentials_async.pytests_async/transport/test_aiohttp_requests.py

clundin25 added2 commits

October 31, 2023 14:17

Merge main.

9236753

Use mainline system test creds.

9eca37e

Copy link

dvzrv commentedMar 5, 2024

Hi! 👋

We are currently (finally) removing the python-mock package on Arch Linux.
I am therefore very interested in this getting merged and released. Are there still specific blockers?