- Notifications
You must be signed in to change notification settings - Fork855
fix: sometimes changes to the draggable prop don't get propagated#994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
| return ( | ||
| !shallowEqual( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
seems to be working well for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's still not working for me. Does the sandbox in the PR description work for you?
When I check the draggable checkbox at the top, only the third map becomes draggable, but not the first two. I would expect these 2 to also be draggable.
This pull request fixes an issue where a change to the draggable prop would not make the map draggable by not omitting the prop inside the
shouldComponentUpdateprop.If we change the prop but there is no other prop change the map behavior won't get updated, as that is done inside the
componentDidUpdatefunction.You can see the issue reproduced in this sandbox:https://codesandbox.io/s/distracted-wright-hrs51?file=/src/App.js
When you make the map draggable only the last map becomes draggable as there is another prop change, while the first 2 can't be dragged (the second one is expected as the code in
componentDidUpdateomits those).Fixes#978