Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add guard around mapDom event listener#594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
itsmichaeldiego merged 1 commit intogoogle-map-react:masterfrombignimbus:master
May 31, 2018

Conversation

bignimbus
Copy link
Contributor

Fixes an issue where, even if the end user has a proper google maps API
mock, the GoogleMaps component will throw an error when in a test
env. ReactDOM.findDOMNode(this.googleMapDom_) returnsnull.

This commit wraps the subsequent addEventListener call in anif block,
ensuring that an empty DOM doesn't add complications to test suites

Thank you for your consideration and your hard work on this great library!

Fixes an issue where, even if the end user has a proper google maps APImock, the GoogleMaps component will throw an error when in a testenv.  ReactDOM.findDOMNode(this.googleMapDom_) returns `null`.This commit wraps the subsequent addEventListener call in an `if` block,ensuring that an empty DOM doesn't add complications to test suites
@itsmichaeldiego
Copy link
Member

itsmichaeldiego commentedMay 31, 2018•
edited
Loading

This is great@bignimbus ! Thanks, someone opened a similar PR but provided not as good description as yours. Merging and it will be present in the next release together with other group of changes as this one is not a blocker.

Thanks again@bignimbus

bignimbus reacted with hooray emoji

@itsmichaeldiegoitsmichaeldiego merged commit99c3c84 intogoogle-map-react:masterMay 31, 2018
@lock
Copy link

lockbot commentedDec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@locklockbot locked asresolvedand limited conversation to collaboratorsDec 1, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@bignimbus@itsmichaeldiego
[8]ページ先頭
©2009-2025 Movatter.jp