Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Move dep for react-dom#592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jooj123
Copy link
Contributor

react-dom should be apeerDep and not adependancy

Consumers should be deciding if they want to include this as part of their bundle not the library

loune, itsmichaeldiego, and JonShort reacted with thumbs up emoji
Copy link
Member

@itsmichaeldiegoitsmichaeldiego left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great work dude! This is getting merged and will be released in 1.0.4

@itsmichaeldiegoitsmichaeldiego merged commitfc062a0 intogoogle-map-react:masterMay 31, 2018
@jooj123jooj123 deleted the patch/fix-deps branchJune 1, 2018 07:53
@jooj123
Copy link
ContributorAuthor

thanks@itsmichaeldiego 👍

@jooj123
Copy link
ContributorAuthor

@itsmichaeldiego any chance we can get this one released?

@prasadhewage
Copy link

@itsmichaeldiego hey, can we have this change soon.

@itsmichaeldiego
Copy link
Member

@jooj123@prasadhewage Sorry guys, I am in holidays in Greece and I haven't been that active.

I released this onv1.0.4

Cheers!

@lock
Copy link

lockbot commentedDec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@locklockbot locked asresolvedand limited conversation to collaboratorsDec 1, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@itsmichaeldiegoitsmichaeldiegoitsmichaeldiego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@jooj123@prasadhewage@itsmichaeldiego
[8]ページ先頭
©2009-2025 Movatter.jp