- Notifications
You must be signed in to change notification settings - Fork855
Refactor code style#533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| const BASE_URL = 'https://maps'; | ||
| const DEFAULT_URL = `${BASE_URL}.googleapis.com`; | ||
| const API_PATH = '/maps/api/js?callback=_$_google_map_initialize_$_'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Moving this string here, makeshttps://github.com/istarkov/google-map-react/pull/533/files#diff-4ed1519a6d20f85caa4cc6b843258ecbR86 way clearer.
| console.error(message); | ||
| throw new Error(message); | ||
| } | ||
| } | ||
| letqueryString = Object.keys(bootstrapURLKeys).reduce( | ||
| letparams = Object.keys(bootstrapURLKeys).reduce( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The wordparams makes more sense thanqueryString, as they're actuallyparams
| withContext, | ||
| withProps, | ||
| withPropsOnChange, | ||
| } from 'recompose'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This way of importing things looks clearer
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This pr includes: