Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Set latest release version as default if user does not specify a version.#530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
itsmichaeldiego merged 4 commits intomasterfrom510-526-set-release-version-default
Mar 10, 2018

Conversation

itsmichaeldiego
Copy link
Member

@itsmichaeldiegoitsmichaeldiego commentedMar 10, 2018
edited
Loading

Closes#510
Closes#526

There are a couple of bugs involved in the latest release of Google Maps, both issues (#510 and#526) were caused by the version3.32 which isexperimental.Quoting Google:

The experimental version — currently 3.32 — contains the latest features and bug fixes as they are made publicly available. Changes made to the experimental version are not guaranteed to be feature stable. We encourage you to regularly test your applications with the experimental version, which you can do by adding v=3.32 when loading the API

We would like our default version to be the latestrelease version, and not the latestexperimental version. To do so we set upv=3 if no version is specified by the user. Which will be, today 3/10/2018,3.31:

The current release version is 3.31. You can request it with either of the following bootstraps:

<script async defer    src="https://maps.googleapis.com/maps/api/js?v=3        &key=YOUR_API_KEY&callback=initMap">
<script async defer    src="https://maps.googleapis.com/maps/api/js?v=3.31        &key=YOUR_API_KEY&callback=initMap">

I am going to use3.31 to make sure that this library works, when3.32 is released, we would need to check if the issues that are affecting us now, will still be affecting us then. But for now, I think this is a good solution, this is also recommended by Google:

In order to make sure that there are no issues arising from version rollover, we recommend that you explicitly specify the number of the current release version of the API in the bootstrap. For example, v=3.31.

Source:https://developers.google.com/maps/documentation/javascript/versions

@domesticmouse
Copy link

As a Googler on the Google Maps Developer Relations team, I can categorically state that this isn't a solution, just a delaying tactic. The advice given by our Google Maps JavaScript API team lead@stephenfarrar in#490 is coming from a place of knowledge. He looks after the API, after all.

I strongly suggest that you investigate fixing this properly by following his advice, and building on the prototype he provided in#510 (comment)

nickmcmillan reacted with thumbs up emoji

@stephenfarrar
Copy link
Contributor

FYI#526 is now fixed in v=3.32

@itsmichaeldiego
Copy link
MemberAuthor

itsmichaeldiego commentedMar 14, 2018
edited
Loading

@domesticmouse Thanks for your message, as a Collaborator on the Open Source Team, I try to unblock current or new users providing a simple solution from our side so they don't have to do extra research to be the problem. This was totally temporary and I never mentioned that this was the final solution, as I stated:

when 3.32 is released, we would need to check if the issues that are affecting us now, will still be affecting us then. But for now, I think this is a good solution, this is alsorecommended by Google

Right now as per@stephenfarrar'scomment. This is fixed and, we do not need to change our code. So, I believe this was a good call.

Thanks both of you@stephenfarrar and@domesticmouse

@stephenfarrar
Copy link
Contributor

@itsmichaeldiego Thanks for clarifying. Requesting 3.31 is exactly what we hope people will do if they encounter bugs in the Maps API like#526.

On the other hand,#490 and its duplicate#510 are not bugs in the Maps API. Rather, I think this library is doing something we don't support (all sorts of assumptions about how animations used to be implemented). I'm hoping that we could work together to remove these assumptions and make the library work even better.

I wasn't sure whether anyone was intending to keep on working at#510, given that the issue was closed. Should we open a new issue?

@itsmichaeldiego
Copy link
MemberAuthor

@stephenfarrar Opening a new issue sounds good, I am also looking forward to fix this! Feel free to message me and we can pair up!

@lock
Copy link

lockbot commentedDec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@locklockbot locked asresolvedand limited conversation to collaboratorsDec 1, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees

@itsmichaeldiegoitsmichaeldiego

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markers are not clickable on mobile Zooming is animating markers from the corners
3 participants
@itsmichaeldiego@domesticmouse@stephenfarrar

[8]ページ先頭

©2009-2025 Movatter.jp