- Notifications
You must be signed in to change notification settings - Fork855
upgrade .babelrc#521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
upgrade .babelrc#521
Uh oh!
There was an error while loading.Please reload this page.
Conversation
itsmichaeldiego commentedMar 6, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@alirezavalizade Please provide description and fix the build |
@itsmichaeldiego what does mean fix the build ? |
@alirezavalizade If you take a look at Github, at the bottom, it says |
@itsmichaeldiego Thank you! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good PR, thanks for this. I left one comment, but besides that it looks good.
.babelrc Outdated
| "loose": true | ||
| }], "react", "stage-0" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can we keep the same format we had before? I think this format is less readable.
Also, we want an empty line at the end of the file, GitHub is warning us here:
Fix format.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Uh oh!
There was an error while loading.Please reload this page.
fix warning on installing packages (🙌 Thanks for using Babel: we recommend using babel-preset-env now: please read babeljs.io/env to update!)