- Notifications
You must be signed in to change notification settings - Fork855
fix error about fromLatLngToDivPixel#517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fix "Cannot read property 'fromLatLngToDivPixel' of undefined"google-map-react#257
jeremymarc commentedFeb 20, 2018
+1 |
1 similar comment
Stosiu commentedFeb 22, 2018
+1 |
loris commentedFeb 22, 2018
+1, same error happening in production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I like this change but we need to keep in mind that there are some binding events under yourreturn; that might get broken, so we should skip only the code that relates to div or overlay
@itsmichaeldiego I addressed your point. please review it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
@fmy@loris@Stosiu@jeremymarc Merged and published in version |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Uh oh!
There was an error while loading.Please reload this page.
fix "Cannot read property 'fromLatLngToDivPixel' of undefined"#257
In my production, errors occurred in the
idleevent handler, not in thedraw()function.I can not find the condition, but I can reproduce this error in local env.
It looks like below.