- Notifications
You must be signed in to change notification settings - Fork855
Fix for usage from China#494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix for usage from China#494
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolasdelfino left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, I approve
@emilpalsson Thanks for this, it is looking good, would you mind adding this to the docs? As soon as you do that I will release a new version fixing this. |
| @@ -62,8 +62,12 @@ export default function googleMapLoader(bootstrapURLKeys) { | |||
| '' | |||
| ); | |||
| const url = bootstrapURLKeys.region === 'cn' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
what about other regions ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@jooj123 I believe the only region that has a problem with this is China. But we could confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Exactly, China is the only region mentioned on the Google Maps FAQ (see link in the issue), and the only region I've experienced problems with.
@itsmichaeldiego Great! Of course, I'll see if I can find a good spot for this in the docs right now. |
@itsmichaeldiego I've added this to the docs, let me know if you want me to structure it differently. I also added a toLocaleLowerCase() for case insensitivity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great work dude!
romanenko commentedJan 19, 2018
Looks like that if region is not set — it leads to uncaught Error now, with 0.28.0 release
I'm setting up my GoogleMap component like this: <GoogleMapbootstrapURLKeys={{key:GOOGLE_MAPS_API_KEY,language:intl.locale,}}//... |
emilpalsson commentedJan 19, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@romanenko Yes, I'm sorry for this. There is already a new PR to fix this (#496). |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Use China specific API URL if setting bootstrapURLKeys.region to 'cn'.
Fixes#493