Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add fullscreen check for Internet explorer 11#485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
itsmichaeldiego merged 3 commits intogoogle-map-react:masterfromomladek:patch-1
Jan 4, 2018

Conversation

omladek
Copy link
Contributor

Fixing marker position in Internet Explorer 11 in fullscreen mode.
Fixing:#484

Fixing marker position in Internet Explorer 11 in fullscreen mode.Fixing:google-map-react#484
Copy link
Member

@itsmichaeldiegoitsmichaeldiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thisif is getting really big, could we create a function calledisFullScreen and move all this logic there to make it cleaner? Thanks.

@omladek
Copy link
ContributorAuthor

Code is moved to functionisFullScreen.

@emilpalsson
Copy link
Contributor

Great job guys, would love to see this merged as well to complete#452. Thanks!

Copy link

@nicolasdelfinonicolasdelfino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, go for it

@itsmichaeldiegoitsmichaeldiego merged commite47d955 intogoogle-map-react:masterJan 4, 2018
@itsmichaeldiego
Copy link
Member

@omladek Good job, thanks!

@lock
Copy link

lockbot commentedDec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@locklockbot locked asresolvedand limited conversation to collaboratorsDec 1, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@itsmichaeldiegoitsmichaeldiegoitsmichaeldiego approved these changes

@nicolasdelfinonicolasdelfinonicolasdelfino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@omladek@emilpalsson@itsmichaeldiego@nicolasdelfino

[8]ページ先頭

©2009-2025 Movatter.jp