Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

notify call back of load failure#479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
itsmichaeldiego merged 1 commit intogoogle-map-react:masterfromacellam:master
Dec 28, 2017
Merged

notify call back of load failure#479

itsmichaeldiego merged 1 commit intogoogle-map-react:masterfromacellam:master
Dec 28, 2017

Conversation

acellam
Copy link
Contributor

When the google fails to load due to no internet, the call back should be notified so that appropriate UI can be shown

itsmichaeldiego reacted with thumbs up emojiitsmichaeldiego reacted with hooray emoji
Copy link
Member

@itsmichaeldiegoitsmichaeldiego left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please check Travis errorsin here

When the google  fails to load due to no internet, the  call back should be notified so that appropriate UI can be shown
@acellam
Copy link
ContributorAuthor

@itsmichaeldiego thanks for spotting the bug 🐛 . It is because i edited the file on github and not my work station but am glad that the unit tests got me :) i have done a forced push with the correction

itsmichaeldiego reacted with thumbs up emoji

@itsmichaeldiegoitsmichaeldiego merged commit7814901 intogoogle-map-react:masterDec 28, 2017
@lock
Copy link

lockbot commentedDec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@locklockbot locked asresolvedand limited conversation to collaboratorsDec 1, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@itsmichaeldiegoitsmichaeldiegoitsmichaeldiego left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@acellam@itsmichaeldiego
[8]ページ先頭
©2009-2025 Movatter.jp