- Notifications
You must be signed in to change notification settings - Fork855
Fix markers position on fullscreen mode#452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/google_map.js Outdated
| const mapDom = ReactDOM.findDOMNode(this.googleMapDom_); | ||
| this.geoService_.setViewSize(mapDom.clientWidth, mapDom.clientHeight); | ||
| if (document.fullscreen || document.webkitIsFullScreen || document.mozFullScreen) { | ||
| _this.geoService_.setViewSize(window.innerWidth, window.innerHeight); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
_this is not defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed, sorry about that!
Great find@jbcochery! I was just about to start looking for a fix for#296 when I saw your PR. Crazy timing, for an issue 10 month old. Thanks@istarkov for a great lib! |
itsmichaeldiego commentedOct 10, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Wow@emilpalsson same here! I was looking at that issue right now. This is looking great@jbcochery, thank you! And thank you@istarkov for the lib! Looking forward to get this merged. |
nicolasdelfino commentedOct 19, 2017
Any status of when this is getting merged? |
qur2 commentedOct 30, 2017
I also got bitten by that issue. While the fix offered seems to work (thanks for that!), the real problem is that the ref that GooleMapReact keeps does not point to the div used to render the fullscreen map. The fix works because incidentally, the div to which we should have a ref to has the same size than the window. |
MaxFrolov commentedNov 22, 2017
@istarkov Hey, how about merging this fix? |
ShepelievD commentedNov 23, 2017
@istarkov really need this stuff, merge, please! 😢 😢 😢 |
nicolasdelfino commentedNov 23, 2017
@istarkov Please communicate if this is getting merged or not. It would be a shame if people started working on their own forks and this project would stagnate. |
jkettmann commentedNov 24, 2017
@istarkov We also need this fix. Do you plan on merging this? |
Guys I need collaborator-leader of this project, see the readme top. I have no desire now to do anything :-( |
nicolasdelfino commentedNov 28, 2017
@istarkov I understand your position and hope you'll find someone willing to help. I'm sure you'll do. |
This is merged and published. Feel free to upgrade to CC@nicolasdelfino@emilpalsson@minhkl@huwr@paupalou@jkettmann@ShepelievD @Venumteam@qur2@jbcochery |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
On fullscreen mode, the view size should not be computed from the DOM element size, but from the
windowdimensions.Fixes#296