- Notifications
You must be signed in to change notification settings - Fork855
#add handlers for fly update layers#272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -291,6 +294,14 @@ export default class GoogleMap extends Component { | |||
| this.map_.setOptions(options); | |||
| } | |||
| if (!isEqual(nextProps.layerTypes.sort(), this.props.layerTypes.sort())) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
imo it's on user to sort layers, and to support referential equality. I don't like any kind of isEqual + sort checks here.
ipostol commentedNov 7, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@istarkov, removed sort/isEqual logic, left only ref equal |
Thank you! |
0.21.3 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Uh oh!
There was an error while loading.Please reload this page.
Hello, this is update for resolve fly updates layerTypes by new props (now they can inititialize with map 1 time)