Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix ipad dragging issue#233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jooj123
Copy link
Contributor

Fixes#232

Before:
before

After:
after

@istarkov
Copy link
Collaborator

Thank you!
So map somethere in the page will prevent the whole page from moving as usual?
Also this events could be added on the user side? May be just extend help with this solution?

@jooj123
Copy link
ContributorAuthor

I have added this at my end for now - and that works as well.

But it should be in this component because you wont ever need to move the entire page as you drag the map - what would be the purpose of that?

@istarkov
Copy link
Collaborator

For example we have a page:

<content height={100vh}/><content height={100vh}/><map/>

Map is on the third screen from top, but prevents the whole page touchmove events,
it's bad when library prevents something in the world to happen.

@jooj123
Copy link
ContributorAuthor

jooj123 commentedSep 1, 2016
edited
Loading

Oh i see what your saying -@istarkov PR is fixed.
As you can see below touchmove still works for stuff outside of map now (the second drag is on the right of the map):

verylatest

@istarkov
Copy link
Collaborator

Super!!!

jooj123 reacted with thumbs up emoji

@istarkovistarkov merged commit7d1180c intogoogle-map-react:masterSep 1, 2016
@istarkov
Copy link
Collaborator

Thank you!
in npm 0.19.0

zeeke added a commit to smesh-team/google-map-react that referenced this pull requestJan 11, 2017
yoadsn added a commit to yoadsn/google-map-react that referenced this pull requestMar 10, 2017
Using the built in support from google maps would make the component moremobile friendly.This reverts commit7d1180c.
istarkov pushed a commit that referenced this pull requestMar 10, 2017
…334)* Revert "Fix ipad dragging issue (#233)"Using the built in support from google maps would make the component moremobile friendly.This reverts commit7d1180c.* Improve documentation around touch device support* Fix linting errors
@lock
Copy link

lockbot commentedDec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@locklockbot locked asresolvedand limited conversation to collaboratorsDec 1, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panning the map with touch devices is very clunky
2 participants
@jooj123@istarkov

[8]ページ先頭

©2009-2025 Movatter.jp