Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

call zoomControlClickTime on all clicks#211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

alex-e-leon
Copy link
Contributor

fixes an issue where zoomControlClickTime doesn't get called on any clicks not handled by google maps, so if a marker click function should change the zoom level you receive theGoogleMap bounds not eq: error.

@istarkov
Copy link
Collaborator

Thank you!,
Does it visually changes something? The problem was that in chrome zoom had some bad visual effects, and this partially solved that behavior.
Now I don't remember the idea why I move that code line intoif but think that there were some idea, will check in few days.
Also looks likeGoogleMap bounds not eq: warning should be deleted (or guarded with someif) as in most cases this messages are useless.

@alex-e-leon
Copy link
ContributorAuthor

this seems to look ok in chrome.

@istarkov
Copy link
Collaborator

I need to check this with some of our production code, which causes an addition of double raf hack, it will take some time.

alex-e-leon reacted with thumbs up emoji

@itsmichaeldiego
Copy link
Member

@alex-e-leon Thanks for your contribution. We would like to have this change but it is having conflicts. Would you mind to add a commit to fix it? Thanks.

@alex-e-leon
Copy link
ContributorAuthor

@itsmichaeldiego updated

@itsmichaeldiego
Copy link
Member

@alex-e-leon Thanks, I am still a little bit worried about what@istarkov mentionedearlier. As this fix was supposed to improve chrome's visual behavior. Would you mind sharing a test-video? Otherwise give me some time and I will test it thoroughly. Thanks in advance.

@alex-e-leon
Copy link
ContributorAuthor

No problem@itsmichaeldiego I ended up working around the bug, and I haven't worked on this problem in a while, so I don't have any video I can share. I also don't mind if you close it tbh, but if you feel like working on it let me know how you go!

@itsmichaeldiego
Copy link
Member

@alex-e-leon Oh Alex, thanks and no worries. I will take a look and test it as soon as I have some spare time. Thanks for fixing the conflicts!

@itsmichaeldiego
Copy link
Member

@alex-e-leon I will merge this soon for next release.

@itsmichaeldiego
Copy link
Member

@alex-e-leon I am going to merge this soon, sorry for the delay!

@itsmichaeldiegoitsmichaeldiego merged commite4fa5ff intogoogle-map-react:masterMar 10, 2018
@lock
Copy link

lockbot commentedDec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@locklockbot locked asresolvedand limited conversation to collaboratorsDec 1, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@alex-e-leon@istarkov@itsmichaeldiego

[8]ページ先頭

©2009-2025 Movatter.jp