- Notifications
You must be signed in to change notification settings - Fork855
Marker position#1049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Marker position#1049
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/google_map_markers.js Outdated
| center: '-50%', | ||
| bottom: '-100%', | ||
| }; | ||
| const isNotProduction = process.env.NODE_ENV !== 'production'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why do we need this? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We are using it to determine whether to console.error when an invalid prop value is provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Trying to match how proptypes works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok, sounds good! We could call itisProduction instead, and then doif (!isProduction)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Alright :) I will make that update
src/google_map_markers.js Outdated
| @@ -320,10 +331,36 @@ export default class GoogleMapMarkers extends Component { | |||
| ...latLng, | |||
| }; | |||
| const markerPosition = child.props.markerPosition || 'center center'; | |||
itsmichaeldiegoJul 22, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Default should be google map's default, which is center bottom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just for clarity, is that the same thing referenced in the docs? 👆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@IBanda We're changing the default position, yes, therefore we have to update the docs
PR to introduce the markerPosition prop to position the marker in regards to
transform:translate(x,y).The prop takes a string composed of the X axis value and Y axis value separated by a single white space
The prop can take following values for the X axis;
and the following for the Y axis;
For example