- Notifications
You must be signed in to change notification settings - Fork1.5k
bug fix for help from typing package, add test for optional and union#513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View thisfailed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Uh oh!
There was an error while loading.Please reload this page.
dbieber commentedMay 22, 2024
Thanks for putting this together! At a quick glance, this LGTM. One comment inline above. |
Jemeljanov commentedMay 22, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@dbieber it was a little bit different behaviour now it will be Optional[Union[int, str]], the Optional is because the default is None. Now it is more in compliance with the typing in python code and a more robust version than with regular expression. Additional check is to prevent the Optional repetition (one added from python-fire the other from typing package). |
dbieber commentedSep 21, 2024
I only just enabled CI for pull requests so this didn't surface earlier -- it looks like there are some test failures. |
Uh oh!
There was an error while loading.Please reload this page.
Closes#508
Fixed bug where objects from typing instance were not displayed correctly mentioned in#508 and also Union types.
Added tests for typing.Union and typing.Optional
Other notes
Removed comment as the edge case mentioned is handled by new code.
Used arg_type = repr(arg_type).replace('typing.', '') to output a shorter message for user