Commitb722020

authored and

committed

Test current behavior of doubles and floats in RecordProperty

PiperOrigin-RevId: 505104193Change-Id: I4c2758f22ee1321ed6b6662ab2668f6c5b6aa661

1 parent403a968 commitb722020Copy full SHA for b722020

File tree

+21

-4

lines changed

+21

-4

lines changed

Lines changed: 3 additions & 1 deletion

Lines changed: 15 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,20 @@ class PropertyTwo : public testing::Test {`
`39`	`39`	`};`
`40`	`40`
`41`	`41`	`TEST_F(PropertyTwo, TestSomeProperties) {`
	`42`	`+// 'initializing': conversion from 'int' to 'short', possible loss of data`
	`43`	`+GTEST_DISABLE_MSC_WARNINGS_PUSH_(4244)`
	`44`	`+`
	`45`	`+// Floats and doubles are written as int64_t, since RecordProperty takes an`
	`46`	`+// int64_t, so we test that the values written are truncated to int64_t.`
	`47`	`+float float_prop =3.25;`
	`48`	`+RecordProperty("TestFloatProperty", float_prop);`
	`49`	`+`
	`50`	`+double double_prop =4.75;`
	`51`	`+RecordProperty("TestDoubleProperty", double_prop);`
	`52`	`+`
	`53`	`+GTEST_DISABLE_MSC_WARNINGS_POP_()// 4244`
	`54`	`+`
`42`	`55`	`// Validate we can write an unsigned size_t as a property`
`43`		`-size_tprop_two =2;`
`44`		`-RecordProperty("TestSomeProperty",prop_two);`
	`56`	`+size_tsize_t_prop =5;`
	`57`	`+RecordProperty("TestSizetProperty",size_t_prop);`
`45`	`58`	`}`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,9 @@`
`60`	`60`	`<testcase name="TestSomeProperties" file="gtest_xml_outfile2_test_.cc" line="41" status="run" result="completed" time="" timestamp="" classname="PropertyTwo">`
`61`	`61`	`<properties>`
`62`	`62`	`<property name="SetUpProp" value="2"/>`
`63`		`- <property name="TestSomeProperty" value="2"/>`
	`63`	`+ <property name="TestFloatProperty" value="3"/>`
	`64`	`+ <property name="TestDoubleProperty" value="4"/>`
	`65`	`+ <property name="TestSizetProperty" value="5"/>`
`64`	`66`	`<property name="TearDownProp" value="2"/>`
`65`	`67`	`</properties>`
`66`	`68`	`</testcase>`

Comments

(0)