- Notifications
You must be signed in to change notification settings - Fork898
Improve handling of parameters in @-files: add quote-handling for whitespaces in parameters.#931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
kfriedberger wants to merge3 commits intogoogle:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…taining whitespace.Parameters from @-files are no longer simply split at whitespace,but now recognize quotes (single or double quotes allowed),such that parameters can contain whitespace that are kept unmodified.Each parameter can be written as either a quoted string (single or double quotes are allowed) or a plain unquoted string.Surrounding quotes are removed from parameters when parsing.It is possible to have double quotes within a single-quoted string and vice-versa.Such internal quotes remain untouched when parsing.For simplicity, we do not handle escaped quotes.
We do not enforce an ending quote in @-filesand simply close the string on end-fo-file.This might be nicer for the user and does not harm.
baierd commentedApr 24, 2023
Would it be possible to merge this? I am effected by this issue on my Windows machine. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And abort on recursive include of @-files.